Re: [PATCH v1 3/5] ipmi: remove unused PCI probe coded

Corey Minyard
2009-12-02T21:36:26Z

Bela Lubkin wrote:
> Bjorn Helgaas wrote:
>
>
>> The original 5-patch series leaves the PCI base address alone. That's
>> the same as the old behavior for HP devices, and we verified that it
>> works on an HP DL380G6 by disabling SMBIOS/SMPI/PNP detection. (We
>> also verified that, as you would expect, it did NOT work if we increment
>> the base address).
>>
> ...
>
>> So the question is what to do about non-HP PCI IPMI interfaces. The
>> pre-b0defcdbd2b7d code increments the base address, but that's been
>> gone for several years. Since we've had no complaints, and we don't
>> know about any non-HP PCI interfaces, I propose that we just remove
>> that HP-specific adjustment completely, i.e., use this series as-is.
>>
>
> Much older HP systems had a PCI SMIC interface. Are you
> sure those haven't been broken somewhere along the way?
>
> (Please don't say "we don't care about things that old".)
>
Well, I do care, but if it's HP, it will have the same PCI vendor id, so
it should be the same. The change that Bjorn proposed won't actually
change anything in the current kernel, it will just remove some dead
code. So I think everything is ok. If the older HP systems won't work,
we actually haven't changed anything, but I'll take a patch to fix them.

-corey