Re: [PATCH v1 3/5] ipmi: remove unused PCI probe coded

Bjorn Helgaas
2009-12-02T21:48:27Z

On Wednesday 02 December 2009 02:04:09 pm Bela Lubkin wrote:
> Bjorn Helgaas wrote:
>
> > The original 5-patch series leaves the PCI base address alone. That's
> > the same as the old behavior for HP devices, and we verified that it
> > works on an HP DL380G6 by disabling SMBIOS/SMPI/PNP detection. (We
> > also verified that, as you would expect, it did NOT work if we increment
> > the base address).
> ...
> > So the question is what to do about non-HP PCI IPMI interfaces. The
> > pre-b0defcdbd2b7d code increments the base address, but that's been
> > gone for several years. Since we've had no complaints, and we don't
> > know about any non-HP PCI interfaces, I propose that we just remove
> > that HP-specific adjustment completely, i.e., use this series as-is.
>
> Much older HP systems had a PCI SMIC interface. Are you
> sure those haven't been broken somewhere along the way?
>
> (Please don't say "we don't care about things that old".)

I want to make all machines, including old ones, work :-)

Restoring the behavior of incrementing the base address for HP
interfaces *might* fix an old machine that has been broken since
mid 2006 (when b0defcdbd2b7d went in), but we *know* it would
break current machines.

At this point, I think the only real option is to preserve the
behavior we've had since mid 2006 and fix old machines if and
when we discover them.

Bjorn