From: Huang Ying <ying.huang@intel.com>
To: Len Brown <lenb@kernel.org>
Cc: "ak@linux.intel.com" <ak@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: git-apply --whitespace (Re: [PATCH 2/5] ACPI, APEI, APEI supporting infrastructure)
Date: Thu, 31 Dec 2009 09:19:29 +0800 [thread overview]
Message-ID: <1262222369.31401.1.camel@yhuang-dev.sh.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0912302006520.17125@localhost.localdomain>
On Thu, 2009-12-31 at 09:14 +0800, Len Brown wrote:
> > diff --git a/drivers/acpi/apei/Kconfig b/drivers/acpi/apei/Kconfig
> > new file mode 100644
> > index 0000000..4085bdd
> > --- /dev/null
> > +++ b/drivers/acpi/apei/Kconfig
> > @@ -0,0 +1,9 @@
> > +config ACPI_APEI
> > + tristate "ACPI Platform Error Interface (APEI)"
> > + depends on X86
> > + help
> > + APEI allows to report errors (for example from the chipset)
> > + to the operating system. This improves NMI handling
> > + especially. In addition it supports error serialization and
> > + error injection.
> > +
> > diff --git a/drivers/acpi/apei/Makefile b/drivers/acpi/apei/Makefile
>
> FYI, git apply considers a trailing blank line,
> such as the one at the end of the hunk above,
> to be a "whitespace error".
>
> I use --whitespace=strip, which causes git to delete it
> upon checkin. However, that causes the 4th patch in
> this series, which appents to this file, to not apply.
>
> Please don't send patches with trailing blank lines.
> In this case, the blank should come as a "preceeding"
> blank line in the 4th patch...
Sorry about that. I will be more careful in next time.
Best Regards,
Huang Ying
next prev parent reply other threads:[~2009-12-31 1:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-28 6:12 [PATCH -v3 0/5] ACPI, APEI, APEI basic support Huang Ying
2009-12-28 6:12 ` [PATCH 1/5] ACPI, IO memory pre-mapping and atomic accessing Huang Ying
2009-12-28 6:12 ` [PATCH 2/5] ACPI, APEI, APEI supporting infrastructure Huang Ying
2009-12-28 6:12 ` [PATCH 3/5] ACPI, APEI, HEST table parsing Huang Ying
2009-12-28 6:12 ` [PATCH 4/5] ACPI, APEI, EINJ support Huang Ying
2009-12-28 6:12 ` [PATCH 5/5] ACPI, APEI, Document for APEI Huang Ying
2010-01-06 7:14 ` Pavel Machek
2010-01-06 7:16 ` Pavel Machek
2010-01-06 7:21 ` Huang Ying
2010-01-07 7:12 ` Pavel Machek
2010-01-07 7:26 ` Huang Ying
2010-01-07 7:34 ` Pavel Machek
2010-01-06 7:08 ` [PATCH 4/5] ACPI, APEI, EINJ support Pavel Machek
2010-01-06 7:16 ` Huang Ying
2010-01-07 7:12 ` Pavel Machek
2009-12-31 1:14 ` git-apply --whitespace (Re: [PATCH 2/5] ACPI, APEI, APEI supporting infrastructure) Len Brown
2009-12-31 1:19 ` Huang Ying [this message]
2009-12-31 1:19 ` [PATCH -v3 0/5] ACPI, APEI, APEI basic support Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262222369.31401.1.camel@yhuang-dev.sh.intel.com \
--to=ying.huang@intel.com \
--cc=ak@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox