From: Matthew Garrett <mjg@redhat.com>
To: jbarnes@virtuousgeek.org
Cc: linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
achiang@canonical.com, rjw@sisk.pl,
Matthew Garrett <mjg@redhat.com>
Subject: [PATCH] pci: Ensure we re-enable devices on resume
Date: Thu, 22 Apr 2010 09:30:51 -0400 [thread overview]
Message-ID: <1271943051-2671-1-git-send-email-mjg@redhat.com> (raw)
If the firmware puts a device back into D0 state at resume time, we'll
update its state in resume_noirq and thus skip the platform resume code.
Calling that code twice should be safe and we ought to avoid getting to
that point anyway, so remove the check and also allow the platform pci
code to be called for D0.
Fixes USB not being powered after resume on recent Lenovo machines.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
drivers/pci/pci.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 5ea587e..3749912 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -679,7 +679,7 @@ static void __pci_start_power_transition(struct pci_dev *dev, pci_power_t state)
*/
int __pci_complete_power_transition(struct pci_dev *dev, pci_power_t state)
{
- return state > PCI_D0 ?
+ return state >= PCI_D0 ?
pci_platform_power_transition(dev, state) : -EINVAL;
}
EXPORT_SYMBOL_GPL(__pci_complete_power_transition);
@@ -716,10 +716,6 @@ int pci_set_power_state(struct pci_dev *dev, pci_power_t state)
*/
return 0;
- /* Check if we're already there */
- if (dev->current_state == state)
- return 0;
-
__pci_start_power_transition(dev, state);
/* This device is quirked not to be put into D3, so
--
1.7.0.1
next reply other threads:[~2010-04-22 17:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 13:30 Matthew Garrett [this message]
2010-04-22 18:14 ` [PATCH] pci: Ensure we re-enable devices on resume Rafael J. Wysocki
2010-04-22 19:43 ` Alex Chiang
2010-04-22 23:17 ` Jesse Barnes
2010-04-22 23:46 ` Alex Chiang
2010-04-23 0:08 ` [stable] " Greg KH
2010-04-25 4:21 ` Alex Chiang
2010-05-07 20:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271943051-2671-1-git-send-email-mjg@redhat.com \
--to=mjg@redhat.com \
--cc=achiang@canonical.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).