Re: [PATCH] Fix mute key on older Thinkpads by OSI blacklisting them

[Jerone Young <jerone.young@canonical.com>]

On Sat, 2010-04-24 at 22:16 +0100, Matthew Garrett wrote:
> On Sat, Apr 24, 2010 at 03:49:38PM -0500, Jerone Young wrote:
> 
> > The issue is the way Windows does it is through a userspace daemon.  By
> > making it OSI=Linux (just as with the Thinkpads currently already in
> > blacklist.c ..*61 line) the machines just send the OS a key press.
> 
> And how does that userspace daemon receive the event?

Well it's a daemon and a suite. Don't know if you have ever seen a
Thinkpad with Windows? .. but has a lot of Think tools & such. Apart of
these tools is an OSD as well.

What I gather (could be wrong). It waits for some bit to change in th EC
indicating the mute has been changed. Then it alerts Windows that an the
event happens and changes things at that Level (maybe by sending a mute
key press??) .. but at the Windows userspace Level things get muted and
unmuted properly. In turn muting both speakers & headphones.


				Jerone

> > Since newer thinkpads as well as most other OEM machines take this
> > model. It provides a much better user experience then what it is like
> > today.
> 
> It's a model-specific quirk in generic code, so it's massively desirable 
> to avoid this especially since it encourages other OEMs to do the same 
> kind of thing.

As mentioned in the first email, Lenovo has stopped doing this with the
newly release Thinkpads (ex. X201 & T410). By blacklisting these they
act the same as newer Thinkpads.


>