Re: [PATCH] Fix mute key on older Thinkpads by OSI blacklisting them

[Jerone Young <jerone.young@canonical.com>]

On Sat, 2010-04-24 at 22:16 +0100, Matthew Garrett wrote:
> On Sat, Apr 24, 2010 at 03:49:38PM -0500, Jerone Young wrote:
> 
> > The issue is the way Windows does it is through a userspace daemon.  By
> > making it OSI=Linux (just as with the Thinkpads currently already in
> > blacklist.c ..*61 line) the machines just send the OS a key press.
> 
> And how does that userspace daemon receive the event?
> 
> > Since newer thinkpads as well as most other OEM machines take this
> > model. It provides a much better user experience then what it is like
> > today.
> 
> It's a model-specific quirk in generic code, so it's massively desirable 
> to avoid this especially since it encourages other OEMs to do the same 
> kind of thing.

Also to mention Matt that this is already done in the code for the *61
line, T400, T500, R400. All of these are from the same production time
period. Please see drivers/acpi/blacklist.c. 

These machines will not change and are not getting BIOS updates to
change. They have finished there production run.

It may be just me. But I'm failing to see why this is a big deal. If the
others where put in to fix them, newer Thinkpad models have stopped
this behavior, and these Thinkpads will not be getting updated. Users
with these models are going to have a bad experience when it comes to
muting.

I personally use an X301. I would put that in as well, but there is a
little light on it.. that none of the models in the patch have. That
lets you know the hardware mute is on, I've seen some people really like
that (had a proposed patch in last Ubuntu release and got bugs
saying...What happened to my mute light!!).


			Thanks,
				Jerone

>