From: Lin Ming <ming.m.lin@intel.com>
To: Len Brown <lenb@kernel.org>, tony.luck@intel.com
Cc: linux-acpi <linux-acpi@vger.kernel.org>
Subject: [PATCH] acpi: fix early DSDT dmi check warnings on ia64
Date: Thu, 29 Apr 2010 09:42:34 +0800 [thread overview]
Message-ID: <1272505354.9950.16.camel@minggr.sh.intel.com> (raw)
From: Lin Ming <ming.m.lin@intel.com>
Subject: [PATCH] acpi: fix early DSDT dmi check warnings on ia64
Tony Luck saw a lot of warning messages on ia64:
WARNING: at drivers/firmware/dmi_scan.c:423 dmi_matches+0x70/0x160()
dmi check: not initialized yet.
This is caused by commit aa2110c(ACPI: add boot option acpi=copy_dsdt to fix corrupt DSDT).
DMI is not initialized yet in acpi_early_init.
This patch checks the availability of DMI to avoid the warnings.
Tested-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---
drivers/acpi/bus.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 49af19b..047de07 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -847,8 +847,10 @@ void __init acpi_early_init(void)
/*
* If the machine falls into the DMI check table,
* DSDT will be copied to memory
+ * Only check x86, it's too early to check dmi for ia64
*/
- dmi_check_system(dsdt_dmi_table);
+ if (dmi_available)
+ dmi_check_system(dsdt_dmi_table);
status = acpi_reallocate_root_table();
if (ACPI_FAILURE(status)) {
next reply other threads:[~2010-04-29 1:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 1:42 Lin Ming [this message]
2010-04-29 14:42 ` [PATCH] acpi: fix early DSDT dmi check warnings on ia64 Len Brown
2010-04-29 15:56 ` Bjorn Helgaas
2010-04-29 18:12 ` Luck, Tony
2010-04-29 22:12 ` Luck, Tony
2010-05-06 1:58 ` Lin Ming
2010-05-11 2:09 ` Lin Ming
2010-05-11 23:01 ` Luck, Tony
2010-05-12 1:26 ` Lin Ming
2010-05-20 3:56 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272505354.9950.16.camel@minggr.sh.intel.com \
--to=ming.m.lin@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox