From: Lin Ming <ming.m.lin@intel.com>
To: Len Brown <lenb@kernel.org>, Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: "Moore, Robert" <robert.moore@intel.com>,
linux-acpi <linux-acpi@vger.kernel.org>
Subject: Re: ACPICA Release 20100528 linuxized patches
Date: Wed, 02 Jun 2010 10:13:57 +0800 [thread overview]
Message-ID: <1275444837.3431.11.camel@minggr.sh.intel.com> (raw)
In-Reply-To: <1275296862.7586.64.camel@minggr.sh.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2212 bytes --]
Hi, Len
It's reported that patch 11 has a bug, see
http://www.acpica.org/bugzilla/show_bug.cgi?id=863
Please apply this new version of mbox, the only difference is as below.
Alexey,
The reporter confirmed that removing the "Handle the simple case here"
code fixes bug 863.
diff --git a/drivers/acpi/acpica/exfldio.c b/drivers/acpi/acpica/exfldio.c
index 38293fd..00a444f 100644
--- a/drivers/acpi/acpica/exfldio.c
+++ b/drivers/acpi/acpica/exfldio.c
@@ -698,15 +698,7 @@ acpi_ex_extract_from_field(union acpi_operand_object *obj_desc,
ACPI_MEMSET(buffer, 0, buffer_length);
access_bit_width = ACPI_MUL_8(obj_desc->common_field.access_byte_width);
- /* Handle the simple case here */
-
- if ((obj_desc->common_field.start_field_bit_offset == 0) &&
- (obj_desc->common_field.bit_length == access_bit_width)) {
- status = acpi_ex_field_datum_io(obj_desc, 0, buffer, ACPI_READ);
- return_ACPI_STATUS(status);
- }
-
/* TBD: Move to common setup code */
/* Field algorithm is limited to sizeof(u64), truncate if needed */
On Mon, 2010-05-31 at 17:07 +0800, Lin Ming wrote:
> Hi, Len
>
> ACPICA Release 20100528 linuxized patches attached.
> Applied cleanly on top of linus tree(67a3e12).
>
> [PATCH 01/14] ACPICA: Add comment: _BCL cannot be sorted on the fly
> [PATCH 02/14] ACPICA: Fix namestring associated with AE_NO_HANDLER exception
> [PATCH 03/14] ACPICA: iASL/Core: Add support for _WDG/_WED MS methods
> [PATCH 04/14] ACPICA: Expand initialization counters to 32 bits
> [PATCH 05/14] ACPICA: Limit maximum time for Sleep() operator
> [PATCH 06/14] ACPICA: Core: Replace all %d format specifiers with %u (unsigned)
> [PATCH 07/14] ACPICA: Expand device initialization counters to 32 bits
> [PATCH 08/14] ACPICA: Truncate I/O addresses to 16 bits for Windows compatibility
> [PATCH 09/14] ACPICA: Performance enhancement for namespace search and access
> [PATCH 10/14] ACPICA: Update flags for operand object
> [PATCH 11/14] ACPICA: Enable multi-byte EC transfers
> [PATCH 12/14] ACPICA: Optimization: Reduce the number of namespace walks
> [PATCH 13/14] ACPICA: Add signatures for undefined tables: ATKG, GSCI, IEIT
> [PATCH 14/14] ACPICA: Update version to 20100528
>
> Lin Ming
[-- Attachment #2: acpica-v20100528_multi-byte-ec-fix.mbox --]
[-- Type: application/mbox, Size: 67862 bytes --]
next prev parent reply other threads:[~2010-06-02 2:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 9:07 ACPICA Release 20100528 linuxized patches Lin Ming
2010-06-02 2:13 ` Lin Ming [this message]
2010-06-02 9:37 ` Alexey Starikovskiy
2010-06-02 10:06 ` Alexey Starikovskiy
2010-06-04 17:46 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275444837.3431.11.camel@minggr.sh.intel.com \
--to=ming.m.lin@intel.com \
--cc=astarikovskiy@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).