public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jerone Young <jerone.young@canonical.com>
To: Pedro Ribeiro <pedrib@gmail.com>
Cc: Kamal Mostafa <kamal@canonical.com>,
	linux-acpi@vger.kernel.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [RFC PATCH 0/2] i915 brightness control
Date: Sat, 05 Jun 2010 03:47:39 +0800	[thread overview]
Message-ID: <1275680859.1828.1161.camel@laptop> (raw)
In-Reply-To: <AANLkTiktSDWqHg_A8V5_jQsCf1w4k5x9Q7ZOCjAIZTEH@mail.gmail.com>

On Thu, 2010-06-03 at 00:20 +0100, Pedro Ribeiro wrote:
> On 2 June 2010 23:11, Kamal Mostafa <kamal@canonical.com> wrote:
> > Requesting comments on this idea (proposed by Matthew Garrett) and my
> > implementation.  Note especially the KNOWN PROBLEM with a "GM45" GPU.
> >
> >  -Kamal
> >
> > .......
> >
> > BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/568611
> >
> > In order to avoid the often-dysfunctional native acpi brightness control
> > methods, a new acpi_brightness_hook interface is made available.
> >
> > The i915 driver uses the new hook to take over brightness control.
> > Boot with i915.brightness=0 to disable.
> >
> > KNOWN PROBLEM:
> >  - i915 opregion brightness control silently fails on GM45 (pci-id 0x2a42)
> >
> > [RFC PATCH 1/2] acpi/video: acpi_brightness_hook API
> > [RFC PATCH 2/2] drm/i915: override acpi brightness control
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> >
> 
> Are you sure this is a good idea to enable it by default just because
> of a problem with one manufacturer (Dell)?

This issue is with many manufactures. From this bug you can see HP
machines are effected also.

https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/568611
> 
> My Lenovo laptop has fine brightness control with a GM45 and this may break it.
> Might be safer only to enable it for laptops with known problems.
> 
> 
> Regards,
> Pedro
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



  parent reply	other threads:[~2010-06-04 19:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-02 22:11 [RFC PATCH 0/2] i915 brightness control Kamal Mostafa
2010-06-02 22:11 ` [RFC PATCH 1/2] acpi/video: acpi_brightness_hook API Kamal Mostafa
2010-06-02 22:11 ` [RFC PATCH 2/2] drm/i915: override acpi brightness control Kamal Mostafa
2010-06-02 23:20 ` [Intel-gfx] [RFC PATCH 0/2] i915 " Pedro Ribeiro
2010-06-03 14:19   ` Matthew Garrett
2010-06-04 19:47   ` Jerone Young [this message]
2010-09-13 17:48 ` Matthew Garrett
2010-09-24 19:12   ` Kamal Mostafa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275680859.1828.1161.camel@laptop \
    --to=jerone.young@canonical.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kamal@canonical.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=pedrib@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox