From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Len Brown <lenb@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: 2.6.35-rc3 regression: IBM Maia system is unbootable [ACPI related?]
Date: Tue, 29 Jun 2010 11:49:08 -0500 [thread overview]
Message-ID: <1277830148.4379.14.camel@mulgrave.site> (raw)
In-Reply-To: <alpine.LFD.2.00.1006282346320.16755@localhost.localdomain>
On Mon, 2010-06-28 at 23:49 -0400, Len Brown wrote:
> From: Len Brown <len.brown@intel.com>
> Subject: [PATCH] ACPI: handle systems which asynchoronously enable ACPI mode
>
> Folklore suggested that such systems existed
> in the pre-history of ACPI.
>
> However, we removed the SCI_EN polling loop from
> acpi_hw_set_mode() in b430acbd7c4b919886fa7fd92eeb7a695f1940d3
> because it delayed resume by 3 seconds on boxes
> that refused to set SCI_EN.
>
> Matthew removed the call to acpi_enable() from
> the suspend resume path.
>
> James found a modern system that still needs to be polled
> upon boot.
>
> So here we restore the workaround, except that we
> put it in acpi_enable() rather than the low level
> acpi_hw_set_mode().
>
> https://bugzilla.kernel.org/show_bug.cgi?id=16271
>
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
>
> James, What does the IBM system see with this patch?
The output is this:
[ 0.084088] ACPI: Core revision 20100428
[ 0.119451] ACPI Warning: Platform took > 100 usec to enter ACPI mode (20100428/evxfevnt-106)
[ 0.128231] Setting APIC routing to physical flat
So it's very fast ... actually it's behaving like there's some caching
issue and it needs two reads to return the correct value
James
next prev parent reply other threads:[~2010-06-29 16:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 16:03 2.6.35-rc3 regression: IBM Maia system is unbootable [ACPI related?] James Bottomley
2010-06-21 16:14 ` James Bottomley
2010-06-21 16:18 ` Andi Kleen
2010-06-21 16:33 ` James Bottomley
2010-06-21 16:54 ` James Bottomley
2010-06-21 17:26 ` James Bottomley
2010-06-29 3:49 ` Len Brown
2010-06-29 16:49 ` James Bottomley [this message]
2010-06-22 14:28 ` Maciej Rutecki
2010-06-28 21:59 ` Len Brown
2010-06-29 4:01 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277830148.4379.14.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=andi@firstfloor.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox