From: Huang Ying <ying.huang@intel.com>
To: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andi Kleen <andi@firstfloor.org>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
ACPI <linux-acpi@vger.kernel.org>,
LKLM <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2][Patch-next -v2] ACPI, APEI, HEST Fix the unsuitable usage of platform_data.
Date: Wed, 18 Aug 2010 12:18:01 +0800 [thread overview]
Message-ID: <1282105081.2744.1539.camel@yhuang-dev> (raw)
In-Reply-To: <4C6B1FEF.8010509@np.css.fujitsu.com>
On Wed, 2010-08-18 at 07:49 +0800, Jin Dongming wrote:
> platform_data in hest_parse_ghes() is used for saving the address of entry
> information of erst_tab. When the device is failed to be added, platform_data
> will be freed by platform_device_put(). But the value saved in platform_data
> should not be freed here. If it is done, it will make system panic.
>
> So I think platform_data should save the address of allocated memory
> which saves entry information of erst_tab.
>
> This patch fixed it and I confirmed it on x86_64 next-tree.
>
> Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Acked-by: Huang Ying <ying.huang@intel.com>
Best Regards,
Huang Ying
next prev parent reply other threads:[~2010-08-18 4:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 23:49 [PATCH 2/2][Patch-next -v2] ACPI, APEI, HEST Fix the unsuitable usage of platform_data Jin Dongming
2010-08-18 4:18 ` Huang Ying [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-09-02 2:31 Jin Dongming
2010-09-02 2:33 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282105081.2744.1539.camel@yhuang-dev \
--to=ying.huang@intel.com \
--cc=andi@firstfloor.org \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox