From: David Woodhouse <dwmw2@infradead.org>
To: Ike Panhc <ike.pan@canonical.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Thomas Renninger <trenn@suse.de>, Alan Cox <alan@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Corentin Chary <corentincj@iksaif.net>,
Randy Dunlap <randy.dunlap@oracle.com>,
"Brown, Len" <len.brown@intel.com>,
Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH 0/8] [Resend] ideapad: using EC command to control rf/camera power
Date: Wed, 18 Aug 2010 11:35:19 +0100 [thread overview]
Message-ID: <1282127719.2747.211.camel@localhost> (raw)
In-Reply-To: <1282120564-11324-1-git-send-email-ike.pan@canonical.com>
On Wed, 2010-08-18 at 09:36 +0100, Ike Panhc wrote:
>
> Once the rfkill of a laptop is set to block, it is no way to unblock with Linux
> without driver. Thanks for David Woodhouse wrote the first driver solving this.
>
> But the \_SB_.GECN and \_SB_.DECN are only available on Lenovo ideapad S10-3.
> Using EC command to control rf/camera power is better because I believe every
> ideapads which has VPC2004 device in its DSDT has this common method.
>
> This driver is tested and work fine on Lenovo ideapad B550 and ideapad S10-3.
Works for me too (on S10-3); thanks.
It all looks good, although should we have a delay or a schedule or at
least a cpu_relax() in the read_ec_data() and write_ec_cmd() loops?
Those loops should be using time_before() too, rather than open-coding
the comparison.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2010-08-18 10:35 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 8:36 [PATCH 0/8] [Resend] ideapad: using EC command to control rf/camera power Ike Panhc
2010-08-18 8:36 ` [PATCH 1/8] ideapad: add ACPI helpers Ike Panhc
2010-08-18 8:37 ` [PATCH 2/8] ideapad: check VPC bit before sync rfkill hw status Ike Panhc
2010-08-18 8:37 ` [PATCH 3/8] ideapad: make sure we bind on the correct device Ike Panhc
2010-08-18 13:27 ` Matthew Garrett
2010-08-19 2:51 ` Ike Panhc
2010-08-18 8:38 ` [PATCH 4/8] ideapad: use return value of _CFG to tell if device exist or not Ike Panhc
2010-08-18 8:38 ` [PATCH 5/8] ideapad: use EC command to control camera Ike Panhc
2010-08-18 8:42 ` Oliver Neukum
2010-08-18 8:51 ` Ike Panhc
2010-08-18 8:38 ` [PATCH 6/8] ideapad: rewrite the hw rfkill notify Ike Panhc
2010-08-18 8:38 ` [PATCH 7/8] ideapad: rewrite the sw rfkill set Ike Panhc
2010-08-18 8:38 ` [PATCH 8/8] ideapad: Change the driver name to ideapad_laptop Ike Panhc
2010-08-25 20:56 ` Len Brown
2010-08-26 5:43 ` Corentin Chary
2010-08-26 6:16 ` Ike Panhc
2010-08-26 7:43 ` Corentin Chary
2010-09-01 11:55 ` Ike Panhc
2010-08-18 10:35 ` David Woodhouse [this message]
2010-08-18 13:04 ` [PATCH 0/8] [Resend] ideapad: using EC command to control rf/camera power Ike Panhc
2010-08-18 15:51 ` Mario 'BitKoenig' Holbe
2010-08-19 3:21 ` Ike Panhc
2010-08-19 13:28 ` David Woodhouse
2010-08-19 19:31 ` Mario 'BitKoenig' Holbe
2010-08-20 7:01 ` Ike Panhc
2010-08-20 9:08 ` Mario 'BitKoenig' Holbe
2010-08-23 8:22 ` Ike Panhc
2010-08-25 11:59 ` Ike Panhc
[not found] ` <4C7505A2.3000402@canonical.com>
2010-08-30 18:19 ` Mario 'BitKoenig' Holbe
2010-09-01 11:49 ` Ike Panhc
[not found] ` <4C7E3DE0.7030209@canonical.com>
2010-09-01 19:56 ` Mario 'BitKoenig' Holbe
2010-09-03 9:06 ` Ike Panhc
[not found] ` <4C80BA81.20701@canonical.com>
2010-09-09 18:17 ` Mario 'BitKoenig' Holbe
2010-09-10 6:44 ` Ike Panhc
[not found] ` <4C89D3C0.7040105@canonical.com>
2010-09-10 7:11 ` Mario 'BitKoenig' Holbe
2010-09-15 10:13 ` Ike Panhc
[not found] ` <4C909C57.5030107@canonical.com>
2010-09-15 11:48 ` Mario 'BitKoenig' Holbe
2010-09-15 12:39 ` Ike Panhc
2010-09-16 11:59 ` Ike Panhc
2010-09-21 13:47 ` Mario 'BitKoenig' Holbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282127719.2747.211.camel@localhost \
--to=dwmw2@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=corentincj@iksaif.net \
--cc=ike.pan@canonical.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).