public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	Lin Ming <ming.m.lin@intel.com>, "Brown, Len" <lenb@kernel.org>
Subject: Why is Scope(_TZ_) defined as ACPI_TYPE_THERMAL rather than ACPI_TYPE_LOCAL_SCOPE
Date: Mon, 20 Sep 2010 15:08:17 +0800	[thread overview]
Message-ID: <1284966497.2111.3460.camel@rui> (raw)

Hi, Bob,

this is the code in utglobal.c,
/*
 * Predefined ACPI Names (Built-in to the Interpreter)
 *
 * NOTES:
 * 1) _SB_ is defined to be a device to allow \_SB_._INI to be run
 *    during the initialization sequence.
 * 2) _TZ_ is defined to be a thermal zone in order to allow ASL code to
 *    perform a Notify() operation on it.
 */
const struct acpi_predefined_names acpi_gbl_pre_defined_names[] = {
        {"_GPE", ACPI_TYPE_LOCAL_SCOPE, NULL},
        {"_PR_", ACPI_TYPE_LOCAL_SCOPE, NULL},
        {"_SB_", ACPI_TYPE_DEVICE, NULL},
        {"_SI_", ACPI_TYPE_LOCAL_SCOPE, NULL},
        {"_TZ_", ACPI_TYPE_THERMAL, NULL},
        {"_REV", ACPI_TYPE_INTEGER, (char *)ACPI_CA_SUPPORT_LEVEL},
        {"_OS_", ACPI_TYPE_STRING, ACPI_OS_NAME},
        {"_GL_", ACPI_TYPE_MUTEX, (char *)1},

I found a problem that Linux thermal driver tries to probe _TZ_ because
the _TZ_ ACPI namespace node type suggests it's a thermal device.

I'm wondering why it's a device rather than a scope.
The comment above says ASL code may perform a Notify() operation on it,
but IMO, this notification is meaningless on its own, because _TZ_ can
neither detect the temperature, nor cool the system down, i.e. no action
should be taken on this notification.

So I think we should change the type to ACPI_TYPE_LOCAL_SCOPE, just like
_PR_, _GPE.

BTW: yes, we can do the tricks in Linux/ACPI code, but it's more likely
an ACPICA problem. what do you think?

thanks,
rui


             reply	other threads:[~2010-09-20  7:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-20  7:08 Zhang Rui [this message]
2010-09-20 20:17 ` Why is Scope(_TZ_) defined as ACPI_TYPE_THERMAL rather than ACPI_TYPE_LOCAL_SCOPE Moore, Robert
2010-09-20 20:29 ` Moore, Robert
2010-09-21  0:16   ` Zhang Rui
2010-09-21  0:56     ` Moore, Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284966497.2111.3460.camel@rui \
    --to=rui.zhang@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox