From: Zhang Rui <rui.zhang@intel.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] thermal: make ops constant
Date: Mon, 15 Nov 2010 08:45:25 +0800 [thread overview]
Message-ID: <1289781925.8148.1813.camel@rui> (raw)
In-Reply-To: <20101112102040.3d402252@lxorguk.ukuu.org.uk>
On Fri, 2010-11-12 at 18:20 +0800, Alan Cox wrote:
> On Fri, 12 Nov 2010 08:24:57 +0800
> Zhang Rui <rui.zhang@intel.com> wrote:
>
> > On Thu, 2010-11-11 at 23:27 +0800, Alan Cox wrote:
> > > From: Alan Cox <alan@linux.intel.com>
> > >
> > > And while
> >
> > > touching that function definition
> >
> > agreed.
> >
> > > do something about the disaster of formatting there.
> > >
> > well. this is what we got after running Lindent.
> > Your changes are reverted If I apply your patch and run Lindent again.
> > So maybe this is a problem that should be fixed in Lindent?
>
> Lindent is just a script for indent which is designed to help a human not
> replace them. It's not something to run automatically over code as it
> makes bad mistakes now and then.
>
Oh, I used to run it first when a new file is introduced, although the
result doesn't look quite good for me sometimes.
Thanks for the correction.
thanks,
rui
next prev parent reply other threads:[~2010-11-15 0:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 15:27 [PATCH] thermal: make ops constant Alan Cox
2010-11-12 0:24 ` Zhang Rui
2010-11-12 10:20 ` Alan Cox
2010-11-15 0:45 ` Zhang Rui [this message]
2010-11-15 0:38 ` Zhang Rui
2010-11-20 2:41 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289781925.8148.1813.camel@rui \
--to=rui.zhang@intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox