public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg@redhat.com>
To: x86@kernel.org
Cc: hpa@zytor.com, linux-acpi@vger.kernel.org, lenb@kernel.org,
	linux-kernel@vger.kernel.org, Matthew Garrett <mjg@redhat.com>
Subject: [PATCH 2/3] ACPICA: Fix access width for reset vector
Date: Thu,  9 Dec 2010 16:46:43 -0500	[thread overview]
Message-ID: <1291931204-5854-2-git-send-email-mjg@redhat.com> (raw)
In-Reply-To: <1291931204-5854-1-git-send-email-mjg@redhat.com>

Section 4.7.3.6 of the ACPI specification requires that the register width
of the reset vector be 8 bits. Windows simply hardcodes the access to be
a byte and ignores the width provided in the FADT, so make sure that we
do the same.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
 drivers/acpi/acpica/hwxface.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/acpica/hwxface.c b/drivers/acpi/acpica/hwxface.c
index 50cc3be..c6a4e63 100644
--- a/drivers/acpi/acpica/hwxface.c
+++ b/drivers/acpi/acpica/hwxface.c
@@ -82,12 +82,11 @@ acpi_status acpi_reset(void)
 		/*
 		 * For I/O space, write directly to the OSL. This bypasses the port
 		 * validation mechanism, which may block a valid write to the reset
-		 * register.
+		 * register. Spec section 4.7.3.6 requires register width to be 8.
 		 */
 		status =
 		    acpi_os_write_port((acpi_io_address) reset_reg->address,
-				       acpi_gbl_FADT.reset_value,
-				       reset_reg->bit_width);
+				       acpi_gbl_FADT.reset_value, 8)
 	} else {
 		/* Write the reset value to the reset register */
 
-- 
1.7.3.2

  reply	other threads:[~2010-12-09 21:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-09 21:46 [PATCH 1/3] X86: Revamp reboot behaviour to match Windows more closely Matthew Garrett
2010-12-09 21:46 ` Matthew Garrett [this message]
2010-12-09 22:41   ` [PATCH 2/3] ACPICA: Fix access width for reset vector Rafael J. Wysocki
2010-12-09 23:12   ` H. Peter Anvin
2010-12-09 23:26     ` Matthew Garrett
2010-12-09 21:46 ` [PATCH 3/3] ACPI: Bug compatibility for Windows on the ACPI reboot vector Matthew Garrett
2010-12-09 22:36   ` H. Peter Anvin
2010-12-09 22:41     ` Rafael J. Wysocki
2010-12-09 22:25 ` [PATCH 1/3] X86: Revamp reboot behaviour to match Windows more closely H. Peter Anvin
2010-12-09 22:32   ` Matthew Garrett
2010-12-09 22:32     ` H. Peter Anvin
2010-12-09 22:38       ` Matthew Garrett
2010-12-09 22:40         ` H. Peter Anvin
2010-12-09 22:51           ` Matthew Garrett
2010-12-09 22:53             ` H. Peter Anvin
2010-12-09 22:58               ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291931204-5854-2-git-send-email-mjg@redhat.com \
    --to=mjg@redhat.com \
    --cc=hpa@zytor.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox