* [PATCH] ACPI: Make sure the FADT is at least rev 2 before using the reset register
@ 2010-12-10 17:57 Matthew Garrett
2010-12-13 0:16 ` Zhang Rui
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Garrett @ 2010-12-10 17:57 UTC (permalink / raw)
To: x86; +Cc: hpa, linux-acpi, lenb, linux-kernel, Matthew Garrett
The reset register was only introduced with version 2 of the FADT, so we
should check that the FADT revision before trusting its contents.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
drivers/acpi/reboot.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/reboot.c b/drivers/acpi/reboot.c
index 4870aaa..a6c77e8b 100644
--- a/drivers/acpi/reboot.c
+++ b/drivers/acpi/reboot.c
@@ -15,6 +15,11 @@ void acpi_reboot(void)
rr = &acpi_gbl_FADT.reset_register;
+ /* ACPI reset register was only introduced with v2 of the FADT */
+
+ if (acpi_gbl_FADT.header.revision < 2)
+ return;
+
/* Is the reset register supported? The spec says we should be
* checking the bit width and bit offset, but Windows ignores
* these fields */
--
1.7.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: Make sure the FADT is at least rev 2 before using the reset register
2010-12-10 17:57 [PATCH] ACPI: Make sure the FADT is at least rev 2 before using the reset register Matthew Garrett
@ 2010-12-13 0:16 ` Zhang Rui
2010-12-13 0:21 ` Matthew Garrett
0 siblings, 1 reply; 3+ messages in thread
From: Zhang Rui @ 2010-12-13 0:16 UTC (permalink / raw)
To: Matthew Garrett
Cc: x86@kernel.org, hpa@zytor.com, linux-acpi@vger.kernel.org,
lenb@kernel.org, linux-kernel@vger.kernel.org
On Sat, 2010-12-11 at 01:57 +0800, Matthew Garrett wrote:
> The reset register was only introduced with version 2 of the FADT, so we
> should check that the FADT revision before trusting its contents.
>
does the current code break anything?
I'm curious about how you found this bug. :)
thanks,
rui
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
> ---
> drivers/acpi/reboot.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/acpi/reboot.c b/drivers/acpi/reboot.c
> index 4870aaa..a6c77e8b 100644
> --- a/drivers/acpi/reboot.c
> +++ b/drivers/acpi/reboot.c
> @@ -15,6 +15,11 @@ void acpi_reboot(void)
>
> rr = &acpi_gbl_FADT.reset_register;
>
> + /* ACPI reset register was only introduced with v2 of the FADT */
> +
> + if (acpi_gbl_FADT.header.revision < 2)
> + return;
> +
> /* Is the reset register supported? The spec says we should be
> * checking the bit width and bit offset, but Windows ignores
> * these fields */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: Make sure the FADT is at least rev 2 before using the reset register
2010-12-13 0:16 ` Zhang Rui
@ 2010-12-13 0:21 ` Matthew Garrett
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Garrett @ 2010-12-13 0:21 UTC (permalink / raw)
To: Zhang Rui
Cc: x86@kernel.org, hpa@zytor.com, linux-acpi@vger.kernel.org,
lenb@kernel.org, linux-kernel@vger.kernel.org
On Mon, Dec 13, 2010 at 08:16:36AM +0800, Zhang Rui wrote:
> On Sat, 2010-12-11 at 01:57 +0800, Matthew Garrett wrote:
> > The reset register was only introduced with version 2 of the FADT, so we
> > should check that the FADT revision before trusting its contents.
> >
> does the current code break anything?
> I'm curious about how you found this bug. :)
No, it just seems to be a sensible sanity check.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-13 0:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-10 17:57 [PATCH] ACPI: Make sure the FADT is at least rev 2 before using the reset register Matthew Garrett
2010-12-13 0:16 ` Zhang Rui
2010-12-13 0:21 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox