public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Lin Ming <ming.m.lin@intel.com>
To: lenb <lenb@kernel.org>
Cc: "Moore, Robert" <robert.moore@intel.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-acpi <linux-acpi@vger.kernel.org>
Subject: [PATCH] acpi: update return value in EC gpe handler
Date: Wed, 15 Dec 2010 15:47:08 +0800	[thread overview]
Message-ID: <1292399228.10384.175.camel@minggr.sh.intel.com> (raw)

EC gpe handler should return ACPI_REENABLE_GPE, so acpi_ev_gpe_dispatch
can clear and reenable the GPE.

Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---

Len, 

I forgot to update EC gpe handler return value in the series of 
"[PATCH v2 0/8] Minimize ACPICA/linux GPE code divergence".
This is the fix.

 drivers/acpi/ec.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index e15439a..8a0e907 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -619,7 +619,7 @@ static u32 acpi_ec_gpe_handler(acpi_handle gpe_device,
 		wake_up(&ec->wait);
 		ec_check_sci(ec, acpi_ec_read_status(ec));
 	}
-	return ACPI_INTERRUPT_HANDLED;
+	return ACPI_REENABLE_GPE;
 }
 
 /* --------------------------------------------------------------------------



             reply	other threads:[~2010-12-15  7:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-15  7:47 Lin Ming [this message]
2010-12-15 20:04 ` [PATCH] acpi: update return value in EC gpe handler Moore, Robert
2010-12-17 22:17   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292399228.10384.175.camel@minggr.sh.intel.com \
    --to=ming.m.lin@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox