From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Ying Subject: Re: [PATCH] ACPI, APEI, Generic Hardware Error Source POLL/IRQ/NMI notification type support Date: Wed, 12 Jan 2011 13:00:26 +0800 Message-ID: <1294808427.4596.7.camel@yhuang-dev> References: <1294362425.18956.7.camel@yhuang-dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:60537 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751006Ab1ALFAa (ORCPT ); Wed, 12 Jan 2011 00:00:30 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Len Brown Cc: "linux-kernel@vger.kernel.org" , Andi Kleen , "Luck, Tony" , "linux-acpi@vger.kernel.org" On Wed, 2011-01-12 at 12:55 +0800, Len Brown wrote: > > if (error_block_length > GHES_ESTATUS_MAX_SIZE) { > >- pr_warning(FW_WARN GHES_PFX > >- "Error status block length is too long: %u for " > >- "generic hardware error source: %d.\n", > >+ pr_warning( > >+FW_WARN GHES_PFX "Error status block length is too long: %u for \n" > >+"generic hardware error source: %d.\n", > > error_block_length, generic->header.source_id); > > error_block_length = GHES_ESTATUS_MAX_SIZE; > > Hi Ying, > > I assume that you are tweaking these pr_warning() lines > to beautify the output, but as far as source > code readability, I liked the previous syntax better. > > Although maintainer's opinions vary, I generally do not > strictly enforce the 80 column rule for printk strings. > Ie. I think that code readability with good whitespace > indentation plus printk string grep-ability are more > important than strictly fitting within 80-columns. OK. I will keep the previous format. Best Regards, Huang Ying