From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lin Ming Subject: Re: [PATCH] ACPI: Fix memory leak in acpi_ev_asynch_execute_gpe_method(). Date: Mon, 17 Jan 2011 09:47:11 +0800 Message-ID: <1295228831.28388.84.camel@minggr.sh.intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com ([192.55.52.93]:14051 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729Ab1AQBqp (ORCPT ); Sun, 16 Jan 2011 20:46:45 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jesper Juhl Cc: "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Len Brown On Mon, 2011-01-17 at 03:37 +0800, Jesper Juhl wrote: > We will leak the memory allocated to 'local_gpe_event_info' if > 'acpi_ut_acquire_mutex()' fails or if 'acpi_ev_valid_gpe_event()' fails in > drivers/acpi/acpica/evgpe.c::acpi_ev_asynch_execute_gpe_method(). > > Signed-off-by: Jesper Juhl > --- > evgpe.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/acpi/acpica/evgpe.c b/drivers/acpi/acpica/evgpe.c > index 7c339d3..b6de1fb 100644 > --- a/drivers/acpi/acpica/evgpe.c > +++ b/drivers/acpi/acpica/evgpe.c > @@ -471,6 +471,7 @@ static void ACPI_SYSTEM_XFACE acpi_ev_asynch_execute_gpe_method(void *context) > > status = acpi_ut_acquire_mutex(ACPI_MTX_EVENTS); > if (ACPI_FAILURE(status)) { > + ACPI_FREE(local_gpe_event_info); > return_VOID; > } > > @@ -478,6 +479,7 @@ static void ACPI_SYSTEM_XFACE acpi_ev_asynch_execute_gpe_method(void *context) > > if (!acpi_ev_valid_gpe_event(gpe_event_info)) { > status = acpi_ut_release_mutex(ACPI_MTX_EVENTS); > + ACPI_FREE(local_gpe_event_info); > return_VOID; > } > > Acked-by: Lin Ming Thanks.