From: Lin Ming <ming.m.lin@intel.com>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: linux acpi <linux-acpi@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"Brown, Len" <len.brown@intel.com>,
Matthew Garrett <mjg@redhat.com>
Subject: Re: ACPI notify handler and reentrancy of WMI device.
Date: Thu, 20 Jan 2011 17:55:11 +0800 [thread overview]
Message-ID: <1295517311.11852.7.camel@minggr.sh.intel.com> (raw)
In-Reply-To: <AANLkTinfP+-L2T4oggiTpMwE74V6kxgcrStHumYGiH23@mail.gmail.com>
On Mon, 2011-01-17 at 14:51 +0800, Corentin Chary wrote:
> >> I got an acpi notify handler. The notify is triggered when I call WMBC().
> >> In this notify handler, I must re-call WMBC (with some other arguments, it won't
> >> notify again this time).
> >>
> >> If I do that, I'll get:
> >> [ 176.920391] ACPI Error (dswload-0802): [_T_0] Namespace lookup
> >> failure, AE_ALREADY_EXISTS
> >> [ 176.920416] ACPI Exception: AE_ALREADY_EXISTS, During name
> >> lookup/catalog (20100428/psloop-231)
> >> [ 176.920439] ACPI Error (psparse-0537): Method parse/execution
> >> failed [\AMW0.WMBC] (Node f7023b88), AE_ALREADY_EXISTS
> >> [ 176.920469] ACPI: Marking method WMBC as Serialized because of
> >> AE_ALREADY_EXISTS error
> >
> > Could you attach the acpidump output?
>
> Here it is, and here is the patch I did (I used the workqueue solution
> in this one):
>
> http://git.iksaif.net/?p=acpi4asus.git;a=blobdiff;f=drivers/platform/x86/eeepc-wmi.c;h=725239860bad8d97dabf8b3db4086d6df4b7820b;hp=0d8217d1478028071859ba1a503ba226b3cb33a0;hb=1eac4d6a6fb632314a464e7d52e1dcb1e4780931;hpb=5c5d1a036bb7d38153c6d2102767ef51e5d94ce3
>
> (check eeepc_rfkill_notify, it's triggered when the wlan rfkill is
> blocked: WMBC is called to disable the wlan card, it send a
> notification, the handler is called, the handler want to check the
> wlan card status, it calls WMBC again).
> Thanks;
>
Sorry for late reply.
WMBC is not an ACPI spec defined method (which always start with "_",
_ADR, _DSW etc), the driver should only call ACPI spec defined method.
What does this method do?
And, I don't see any call to WMBC in eeepc-wmi.c or above patch.
Lin Ming
next prev parent reply other threads:[~2011-01-20 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 18:18 ACPI notify handler and reentrancy of WMI device Corentin Chary
[not found] ` <AANLkTim0auvcUeDSO7QGSVbj0A+g88FSon7-qT6KzBHd@mail.gmail.com>
2011-01-17 2:05 ` Lin Ming
2011-01-17 6:51 ` Corentin Chary
2011-01-17 6:52 ` Corentin Chary
2011-01-19 8:15 ` Corentin Chary
2011-01-20 9:55 ` Lin Ming [this message]
2011-01-20 10:00 ` Corentin Chary
2011-01-21 19:55 ` Corentin Chary
2011-01-20 10:10 ` Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295517311.11852.7.camel@minggr.sh.intel.com \
--to=ming.m.lin@intel.com \
--cc=corentin.chary@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox