RE: [RFC 1/2] lib, Make gen_pool memory allocator lockless

Huang Ying
2011-02-10T08:32:51Z

On Thu, 2011-02-10 at 03:03 +0800, Luck, Tony wrote:
> +static int set_bits_ll(unsigned long *addr, unsigned long mask_to_set)
> +{
> + unsigned long val, nval;
> +
> + nval = *addr;
> + do {
> + val = nval;
> + if (val & mask_to_set)
> + return -EBUSY;
> + } while ((nval = cmpxchg(addr, val, val | mask_to_set)) != val);
> +
> + return 0;
> +}
>
> Spin loops like this should have a call to cpu_relax(), shouldn't they?

Thanks! Sounds reasonable to me. Will change it.

Best Regards,
Huang Ying