From: Karthigan Srinivasan <karthigan.srinivasan@hp.com>
To: Nicolas Kaiser <nikai@nikai.net>
Cc: Len Brown <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/acpi/utils.c: Fixed coding style issues
Date: Thu, 21 Apr 2011 11:08:19 -0500 [thread overview]
Message-ID: <1303402099.11855.9.camel@ks-ubuntu> (raw)
In-Reply-To: <20110421102815.5abf133e@absol.kitzblitz>
> You are introducing trailing whitespace.
>
> > return AE_BAD_DATA;
> > - }
> > +
> ^^^^^^^^^^^^^
> For every pair of braces you clean away, you're adding
> two new coding style issues.
Nicolas - appreciate your feedback and apologize for the error. I have
corrected these issues. Re-submitting patch below with corrections.
Best Regards,
Karthigan Srinivasan.
Fixed brace and comment coding style issues is code.
Signed-off-by: Karthigan Srinivasan <karthigan.srinivasan@hp.com>
---
drivers/acpi/utils.c | 15 ++++++---------
1 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
index b002a47..76eaac2 100644
--- a/drivers/acpi/utils.c
+++ b/drivers/acpi/utils.c
@@ -99,9 +99,8 @@ acpi_extract_package(union acpi_object *package,
union acpi_object *element = &(package->package.elements[i]);
- if (!element) {
+ if (!element)
return AE_BAD_DATA;
- }
switch (element->type) {
@@ -185,9 +184,8 @@ acpi_extract_package(union acpi_object *package,
u8 **pointer = NULL;
union acpi_object *element = &(package->package.elements[i]);
- if (!element) {
+ if (!element)
return AE_BAD_DATA;
- }
switch (element->type) {
@@ -303,9 +301,8 @@ acpi_evaluate_reference(acpi_handle handle,
u32 i = 0;
- if (!list) {
+ if (!list)
return AE_BAD_PARAMETER;
- }
/* Evaluate object. */
@@ -337,9 +334,9 @@ acpi_evaluate_reference(acpi_handle handle,
goto end;
}
- if (package->package.count > ACPI_MAX_HANDLES) {
+ if (package->package.count > ACPI_MAX_HANDLES)
return AE_NO_MEMORY;
- }
+
list->count = package->package.count;
/* Extract package data. */
@@ -373,7 +370,7 @@ acpi_evaluate_reference(acpi_handle handle,
end:
if (ACPI_FAILURE(status)) {
list->count = 0;
- //kfree(list->handles);
+ /* kfree(list->handles); */
}
kfree(buffer.pointer);
--
1.7.1
next prev parent reply other threads:[~2011-04-21 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 23:20 [PATCH] drivers/acpi/utils.c: Fixed coding style issues Karthigan Srinivasan
2011-04-21 8:28 ` Nicolas Kaiser
2011-04-21 16:08 ` Karthigan Srinivasan [this message]
2011-05-02 22:16 ` Karthigan Srinivasan
2011-05-03 0:26 ` Joe Perches
2011-05-03 15:09 ` Karthigan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303402099.11855.9.camel@ks-ubuntu \
--to=karthigan.srinivasan@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikai@nikai.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).