From: Karthigan Srinivasan <karthigan.srinivasan@hp.com>
To: Joe Perches <joe@perches.com>, Len Brown <lenb@kernel.org>,
Nicolas Kaiser <nikai@nikai.net>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/acpi/utils.c: Fixed coding style issues
Date: Tue, 03 May 2011 10:09:57 -0500 [thread overview]
Message-ID: <1304435397.2497.4.camel@ks-ubuntu> (raw)
In-Reply-To: <1304382405.7792.53.camel@Joe-Laptop>
> > - //kfree(list->handles);
> > + /* kfree(list->handles); */
> Just delete the line instead.
Len, Joe, Nicolas - re-submitting patch with above recommended change.
Best Regards,
Karthigan.
=========
Fixed brace, comment, and label coding style issues.
Signed-off-by: Karthigan Srinivasan <karthigan.srinivasan@hp.com>
---
drivers/acpi/utils.c | 19 +++++++------------
1 files changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
index b002a47..91289d4 100644
--- a/drivers/acpi/utils.c
+++ b/drivers/acpi/utils.c
@@ -99,9 +99,8 @@ acpi_extract_package(union acpi_object *package,
union acpi_object *element = &(package->package.elements[i]);
- if (!element) {
+ if (!element)
return AE_BAD_DATA;
- }
switch (element->type) {
@@ -185,9 +184,8 @@ acpi_extract_package(union acpi_object *package,
u8 **pointer = NULL;
union acpi_object *element = &(package->package.elements[i]);
- if (!element) {
+ if (!element)
return AE_BAD_DATA;
- }
switch (element->type) {
@@ -303,9 +301,8 @@ acpi_evaluate_reference(acpi_handle handle,
u32 i = 0;
- if (!list) {
+ if (!list)
return AE_BAD_PARAMETER;
- }
/* Evaluate object. */
@@ -337,9 +334,9 @@ acpi_evaluate_reference(acpi_handle handle,
goto end;
}
- if (package->package.count > ACPI_MAX_HANDLES) {
+ if (package->package.count > ACPI_MAX_HANDLES)
return AE_NO_MEMORY;
- }
+
list->count = package->package.count;
/* Extract package data. */
@@ -370,11 +367,9 @@ acpi_evaluate_reference(acpi_handle handle,
list->handles[i]));
}
- end:
- if (ACPI_FAILURE(status)) {
+end:
+ if (ACPI_FAILURE(status))
list->count = 0;
- //kfree(list->handles);
- }
kfree(buffer.pointer);
--
1.7.1
prev parent reply other threads:[~2011-05-03 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 23:20 [PATCH] drivers/acpi/utils.c: Fixed coding style issues Karthigan Srinivasan
2011-04-21 8:28 ` Nicolas Kaiser
2011-04-21 16:08 ` Karthigan Srinivasan
2011-05-02 22:16 ` Karthigan Srinivasan
2011-05-03 0:26 ` Joe Perches
2011-05-03 15:09 ` Karthigan Srinivasan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304435397.2497.4.camel@ks-ubuntu \
--to=karthigan.srinivasan@hp.com \
--cc=joe@perches.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikai@nikai.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).