From: Andrea Righi <andrea@betterlinux.com>
To: Len Brown <lenb@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Borislav Petkov <bp@alien8.de>,
Maciej Rutecki <maciej.rutecki@gmail.com>,
Florian Mickler <florian@mickler.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ACPI: fix acpi_power_off lockdep splat
Date: Sat, 2 Jul 2011 17:31:21 +0200 [thread overview]
Message-ID: <1309620681-25173-1-git-send-email-andrea@betterlinux.com> (raw)
Implement acpi_os_create_lock() as a C-preprocessor macro to assign
unique lock_class_key to dynamically allocated locks and suppress wrong
lockdep warnings.
This fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=38152
Reported-by: Borislav Petkov <bp@alien8.de>
Signed-off-by: Andrea Righi <andrea@betterlinux.com>
---
drivers/acpi/osl.c | 2 +-
include/acpi/acpiosxf.h | 12 +++++++++++-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 52ca964..2a67602 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -1336,7 +1336,7 @@ EXPORT_SYMBOL(acpi_resources_are_enforced);
* Create and initialize a spinlock.
*/
acpi_status
-acpi_os_create_lock(acpi_spinlock *out_handle)
+__acpi_os_create_lock(acpi_spinlock *out_handle)
{
spinlock_t *lock;
diff --git a/include/acpi/acpiosxf.h b/include/acpi/acpiosxf.h
index a756bc8..4a0385d 100644
--- a/include/acpi/acpiosxf.h
+++ b/include/acpi/acpiosxf.h
@@ -99,7 +99,17 @@ acpi_os_table_override(struct acpi_table_header *existing_table,
* Spinlock primitives
*/
acpi_status
-acpi_os_create_lock(acpi_spinlock *out_handle);
+__acpi_os_create_lock(acpi_spinlock *out_handle);
+
+#define acpi_os_create_lock(__handle) \
+({ \
+ acpi_status ret; \
+ \
+ ret = __acpi_os_create_lock(__handle); \
+ if (ret == AE_OK) \
+ spin_lock_init(*(__handle)); \
+ ret; \
+})
void acpi_os_delete_lock(acpi_spinlock handle);
--
1.7.4.1
next reply other threads:[~2011-07-02 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-02 15:31 Andrea Righi [this message]
2011-07-03 6:58 ` [PATCH] ACPI: fix acpi_power_off lockdep splat Rafael J. Wysocki
2011-07-03 8:21 ` Florian Mickler
2011-07-03 8:35 ` Andrea Righi
2011-07-03 8:36 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309620681-25173-1-git-send-email-andrea@betterlinux.com \
--to=andrea@betterlinux.com \
--cc=bp@alien8.de \
--cc=florian@mickler.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox