From: Thomas Renninger <trenn@suse.de>
To: lenb@kernel.org
Cc: trenn@suse.de, linux-acpi@vger.kernel.org
Subject: [PATCH 1/5] ACPI processor: Do not export acpi_idle_driver in processor.h
Date: Thu, 17 Nov 2011 23:36:57 +0100 [thread overview]
Message-ID: <1321569421-46220-2-git-send-email-trenn@suse.de> (raw)
In-Reply-To: <1321569421-46220-1-git-send-email-trenn@suse.de>
Instead move its declaration from processor_idle.c to processor_driver.c
and declare it static as it's the only file using this struct.
Cleanup only, no functional change.
Signed-off-by: Thomas Renninger <trenn@suse.de>
CC: Len Brown <lenb@kernel.org>
CC: linux-acpi@vger.kernel.org
---
drivers/acpi/processor_driver.c | 5 +++++
drivers/acpi/processor_idle.c | 5 -----
include/acpi/processor.h | 1 -
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
index a4e0f1b..3a4fc0c 100644
--- a/drivers/acpi/processor_driver.c
+++ b/drivers/acpi/processor_driver.c
@@ -106,6 +106,11 @@ static struct acpi_driver acpi_processor_driver = {
},
};
+static struct cpuidle_driver acpi_idle_driver = {
+ .name = "acpi_idle",
+ .owner = THIS_MODULE,
+};
+
#define INSTALL_NOTIFY_HANDLER 1
#define UNINSTALL_NOTIFY_HANDLER 2
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 9b88f98..7fed4f3 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -968,11 +968,6 @@ static int acpi_idle_enter_bm(struct cpuidle_device *dev,
return idle_time;
}
-struct cpuidle_driver acpi_idle_driver = {
- .name = "acpi_idle",
- .owner = THIS_MODULE,
-};
-
/**
* acpi_processor_setup_cpuidle - prepares and configures CPUIDLE
* @pr: the ACPI processor
diff --git a/include/acpi/processor.h b/include/acpi/processor.h
index 67055f1..5b27bc3 100644
--- a/include/acpi/processor.h
+++ b/include/acpi/processor.h
@@ -333,7 +333,6 @@ int acpi_processor_power_exit(struct acpi_processor *pr,
struct acpi_device *device);
int acpi_processor_suspend(struct acpi_device * device, pm_message_t state);
int acpi_processor_resume(struct acpi_device * device);
-extern struct cpuidle_driver acpi_idle_driver;
/* in processor_thermal.c */
int acpi_processor_get_limit_info(struct acpi_processor *pr);
--
1.7.6.1
next parent reply other threads:[~2011-11-17 22:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1321569421-46220-1-git-send-email-trenn@suse.de>
2011-11-17 22:36 ` Thomas Renninger [this message]
2012-01-17 11:25 ` [PATCH 1/5] ACPI processor: Do not export acpi_idle_driver in processor.h Len Brown
2012-01-17 14:08 ` Thomas Renninger
2011-11-17 22:36 ` [PATCH 2/5] ACPI processor: Avoid WARN message on processor driver removal Thomas Renninger
2012-01-17 11:02 ` Len Brown
2012-01-17 14:25 ` Thomas Renninger
2012-01-17 14:41 ` Bjorn Helgaas
2012-01-17 14:58 ` Thomas Renninger
2011-11-17 22:36 ` [PATCH 3/5] intel_idle: Split up and provide per CPU initialization func Thomas Renninger
2011-11-17 22:44 ` Thomas Renninger
2012-01-17 11:06 ` Len Brown
2012-01-17 13:26 ` Thomas Renninger
2012-01-17 16:10 ` Thomas Renninger
2011-11-17 22:37 ` [PATCH 4/5] ACPI processor: Fix error path, also remove sysdev link Thomas Renninger
2011-11-17 22:37 ` [PATCH 5/5] ACPI processor: Remove unneeded variable passed by acpi_processor_hotadd_init Thomas Renninger
2012-01-17 11:10 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321569421-46220-2-git-send-email-trenn@suse.de \
--to=trenn@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).