From: Thomas Renninger <trenn@suse.de>
To: lenb@kernel.org
Cc: trenn@suse.de, linux-acpi@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH 2/5] ACPI processor: Avoid WARN message on processor driver removal
Date: Thu, 17 Nov 2011 23:36:58 +0100 [thread overview]
Message-ID: <1321569421-46220-3-git-send-email-trenn@suse.de> (raw)
In-Reply-To: <1321569421-46220-1-git-send-email-trenn@suse.de>
Only unregister acpi_idle driver if acpi_idle driver got
registered.
Also add a static acpi_idle_active variable for easy and nicer
checking whether acpi_idle_driver is active (as suggested by
Bjorn).
Signed-off-by: Thomas Renninger <trenn@suse.de>
CC: Len Brown <lenb@kernel.org>
CC: linux-acpi@vger.kernel.org
CC: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/acpi/processor_driver.c | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
index 3a4fc0c..790623f 100644
--- a/drivers/acpi/processor_driver.c
+++ b/drivers/acpi/processor_driver.c
@@ -110,6 +110,7 @@ static struct cpuidle_driver acpi_idle_driver = {
.name = "acpi_idle",
.owner = THIS_MODULE,
};
+static int acpi_idle_active;
#define INSTALL_NOTIFY_HANDLER 1
#define UNINSTALL_NOTIFY_HANDLER 2
@@ -508,8 +509,7 @@ static int __cpuinit acpi_processor_add(struct acpi_device *device)
acpi_processor_get_throttling_info(pr);
acpi_processor_get_limit_info(pr);
-
- if (cpuidle_get_driver() == &acpi_idle_driver)
+ if (acpi_idle_active)
acpi_processor_power_init(pr, device);
pr->cdev = thermal_cooling_device_register("Processor", device,
@@ -808,6 +808,7 @@ static int __init acpi_processor_init(void)
if (!cpuidle_register_driver(&acpi_idle_driver)) {
printk(KERN_DEBUG "ACPI: %s registered with cpuidle\n",
acpi_idle_driver.name);
+ acpi_idle_active = 1;
} else {
printk(KERN_DEBUG "ACPI: acpi_idle yielding to %s\n",
cpuidle_get_driver()->name);
@@ -828,7 +829,8 @@ static int __init acpi_processor_init(void)
return 0;
out_cpuidle:
- cpuidle_unregister_driver(&acpi_idle_driver);
+ if (acpi_idle_active)
+ cpuidle_unregister_driver(&acpi_idle_driver);
return result;
}
@@ -846,7 +848,8 @@ static void __exit acpi_processor_exit(void)
acpi_bus_unregister_driver(&acpi_processor_driver);
- cpuidle_unregister_driver(&acpi_idle_driver);
+ if (acpi_idle_active)
+ cpuidle_unregister_driver(&acpi_idle_driver);
return;
}
--
1.7.6.1
next prev parent reply other threads:[~2011-11-17 22:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1321569421-46220-1-git-send-email-trenn@suse.de>
2011-11-17 22:36 ` [PATCH 1/5] ACPI processor: Do not export acpi_idle_driver in processor.h Thomas Renninger
2012-01-17 11:25 ` Len Brown
2012-01-17 14:08 ` Thomas Renninger
2011-11-17 22:36 ` Thomas Renninger [this message]
2012-01-17 11:02 ` [PATCH 2/5] ACPI processor: Avoid WARN message on processor driver removal Len Brown
2012-01-17 14:25 ` Thomas Renninger
2012-01-17 14:41 ` Bjorn Helgaas
2012-01-17 14:58 ` Thomas Renninger
2011-11-17 22:36 ` [PATCH 3/5] intel_idle: Split up and provide per CPU initialization func Thomas Renninger
2011-11-17 22:44 ` Thomas Renninger
2012-01-17 11:06 ` Len Brown
2012-01-17 13:26 ` Thomas Renninger
2012-01-17 16:10 ` Thomas Renninger
2011-11-17 22:37 ` [PATCH 4/5] ACPI processor: Fix error path, also remove sysdev link Thomas Renninger
2011-11-17 22:37 ` [PATCH 5/5] ACPI processor: Remove unneeded variable passed by acpi_processor_hotadd_init Thomas Renninger
2012-01-17 11:10 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321569421-46220-3-git-send-email-trenn@suse.de \
--to=trenn@suse.de \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).