From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Ying Subject: RE: [PATCH 2/2] ACPICA: support Generic Address Structure bit_offset in acpi_read/write Date: Thu, 01 Dec 2011 08:57:45 +0800 Message-ID: <1322701065.4849.69.camel@yhuang-dev> References: <20111111230347.20897.28797.stgit@bhelgaas.mtv.corp.google.com> <201111172127.40664.rjw@sisk.pl> <1321578279.13860.108.camel@yhuang-dev> <201111181025.58650.rjw@sisk.pl> <1321861880.13860.128.camel@yhuang-dev> <987664A83D2D224EAE907B061CE93D53027D89B5A9@orsmsx505.amr.corp.intel.com> <1322532903.4849.24.camel@yhuang-dev> <0207C53569FE594381A4F2EB66570B2A018ED45AA8@orsmsx508.amr.corp.intel.com> <1322700551.4849.66.camel@yhuang-dev> <0207C53569FE594381A4F2EB66570B2A018ED45DA7@orsmsx508.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:56907 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753522Ab1LAA5v (ORCPT ); Wed, 30 Nov 2011 19:57:51 -0500 In-Reply-To: <0207C53569FE594381A4F2EB66570B2A018ED45DA7@orsmsx508.amr.corp.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Luck, Tony" Cc: "Rafael J. Wysocki" , Russell King , Bjorn Helgaas , Thomas Renninger , Len Brown , "Moore, Robert" , "linux-acpi@vger.kernel.org" , "bondd@us.ibm.com" , Myron Stowe On Thu, 2011-12-01 at 08:53 +0800, Luck, Tony wrote: > > Is it possible to use the page_is_ram() and kamp() path in the patch to avoid the situation you mentioned? > > Maybe - it could certainly check the current attributes and match them. > > Not sure whether there might be a gap if the acpi mapping is long-lived, > and the other kernel mappings change ... though this is very rare to > switch attributes In the original acpi_read/write, we just call ioremap blindly, so the code in the below patch will not introduce new issue for ia64. Do you agree? https://lkml.org/lkml/2011/11/7/567 Best Regards, Huang Ying