From: Andi Kleen <andi@firstfloor.org>
To: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
mjg@redhat.com, Andi Kleen <ak@linux.intel.com>,
jbarnes@virtuousgeek.org
Subject: [PATCH 5/5] Disable MCP limit exceeded messages from Intel IPS driver
Date: Mon, 6 Feb 2012 08:17:12 -0800 [thread overview]
Message-ID: <1328545032-21373-6-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1328545032-21373-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
On a system on the thermal limit these are quite noisy and flood the logs.
Better would be a counter anyways. But given that we don't even have
anything for normal throttling this doesn't seem to be urgent either.
Cc: jbarnes@virtuousgeek.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
drivers/platform/x86/intel_ips.c | 13 ++-----------
1 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
index 809a3ae..84bba52 100644
--- a/drivers/platform/x86/intel_ips.c
+++ b/drivers/platform/x86/intel_ips.c
@@ -620,25 +620,16 @@ static bool mcp_exceeded(struct ips_driver *ips)
bool ret = false;
u32 temp_limit;
u32 avg_power;
- const char *msg = "MCP limit exceeded: ";
spin_lock_irqsave(&ips->turbo_status_lock, flags);
temp_limit = ips->mcp_temp_limit * 100;
- if (ips->mcp_avg_temp > temp_limit) {
- dev_info(&ips->dev->dev,
- "%sAvg temp %u, limit %u\n", msg, ips->mcp_avg_temp,
- temp_limit);
+ if (ips->mcp_avg_temp > temp_limit)
ret = true;
- }
avg_power = ips->cpu_avg_power + ips->mch_avg_power;
- if (avg_power > ips->mcp_power_limit) {
- dev_info(&ips->dev->dev,
- "%sAvg power %u, limit %u\n", msg, avg_power,
- ips->mcp_power_limit);
+ if (avg_power > ips->mcp_power_limit)
ret = true;
- }
spin_unlock_irqrestore(&ips->turbo_status_lock, flags);
--
1.7.7
next prev parent reply other threads:[~2012-02-06 16:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 16:17 Updated throttling fix patchkit Andi Kleen
2012-02-06 16:17 ` [PATCH 1/5] ACPI: ec: Do request_region outside WARN() Andi Kleen
2012-03-22 6:08 ` Len Brown
2012-02-06 16:17 ` [PATCH 2/5] ACPI: Make ACPI interrupt threaded Andi Kleen
2012-02-06 16:17 ` [PATCH 4/5] ACPI: Do cpufreq clamping for throttling per package v2 Andi Kleen
2012-02-06 16:31 ` Matthew Garrett
2012-02-06 17:59 ` Andi Kleen
2012-02-13 23:30 ` Len Brown
2012-02-14 0:17 ` Matthew Garrett
2012-03-22 6:13 ` Len Brown
2012-03-30 10:05 ` Len Brown
2012-03-30 11:46 ` Matthew Garrett
2012-03-30 12:00 ` Len Brown
2012-02-06 16:17 ` Andi Kleen [this message]
2012-02-07 19:45 ` [PATCH 5/5] Disable MCP limit exceeded messages from Intel IPS driver Jesse Barnes
2012-03-22 6:25 ` Len Brown
[not found] ` <1328545032-21373-4-git-send-email-andi@firstfloor.org>
2012-02-06 16:27 ` [PATCH 3/5] ACPI: EC: Add a limited number of repeats after false EC interrupts Matthew Garrett
2012-02-06 18:01 ` Andi Kleen
2012-02-06 16:31 ` Updated throttling fix patchkit Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328545032-21373-6-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).