From: Shuah Khan <shuahkhan@gmail.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: shuahkhan@gmail.com, lenb@kernel.org, linux-acpi@vger.kernel.org,
bhelgaas@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] ACPI: Add _OST support for sysfs eject
Date: Thu, 10 May 2012 09:40:28 -0600 [thread overview]
Message-ID: <1336664428.2581.21.camel@lorien2> (raw)
In-Reply-To: <1336587377.16730.150.camel@misato.fc.hp.com>
On Wed, 2012-05-09 at 12:16 -0600, Toshi Kani wrote:
> > >
> > > Added macro definitions of _OST source events and status codes.
> > > Also renamed OSC_SB_CPUHP_OST_SUPPORT to OSC_SB_HOTPLUG_OST_SUPPORT
> > > since this _OSC bit is not specific to CPU hotplug. This bit is
> > > defined in Table 6-147 of ACPI 5.0 as follows.
Sorry. Missed that. It was in patch 7. Any reason why this feature is
split across 7 patches? Might be better to combine patches 1, 2, and 7
as it contains the infrastructure type code for _OST. Something to
consider.
There is no functional change with this patch set in the sense that _OST
doesn't get evaluated on platforms that don't support _OST, however
there is run-time change on all architectures with patches 3, 4, and 5.
There are couple of new kfree() calls introduced. Something to take a
closer to make sure it is safe in that path.
Also, what missing functionality does evaluating _OST add to the kernel?
What happens if OS continues to not evaluate _OST? It is an optional
method, looking for what is the value add?
-- Shuah
next prev parent reply other threads:[~2012-05-10 15:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 20:12 [PATCH v2 0/7] ACPI: Add _OST support for ACPI hotplug Toshi Kani
2012-05-08 20:12 ` [PATCH v2 1/7] ACPI: Add CONFIG_HOTPLUG_OST option Toshi Kani
2012-05-10 16:40 ` Jiang Liu
2012-05-10 17:26 ` Toshi Kani
2012-05-10 17:43 ` Jiang Liu
2012-05-10 18:20 ` Toshi Kani
2012-05-11 0:15 ` Jiang Liu
2012-05-08 20:12 ` [PATCH v2 2/7] ACPI: Add an interface to evaluate _OST Toshi Kani
2012-05-08 20:12 ` [PATCH v2 3/7] ACPI: Add _OST support for sysfs eject Toshi Kani
2012-05-09 16:46 ` Shuah Khan
2012-05-09 18:16 ` Toshi Kani
2012-05-10 15:40 ` Shuah Khan [this message]
2012-05-10 16:34 ` Toshi Kani
2012-05-10 16:55 ` Shuah Khan
2012-05-10 17:41 ` Toshi Kani
2012-05-08 20:12 ` [PATCH v2 4/7] ACPI: Add _OST support for ACPI CPU hotplug Toshi Kani
2012-05-08 20:12 ` [PATCH v2 5/7] ACPI: Add _OST support for ACPI memory hotplug Toshi Kani
2012-05-08 20:12 ` [PATCH v2 6/7] ACPI: Add _OST support for ACPI container hotplug Toshi Kani
2012-05-08 20:12 ` [PATCH v2 7/7] ACPI: Set hotplug _OST support bit to _OSC Toshi Kani
2012-05-09 17:36 ` [PATCH v2 0/7] ACPI: Add _OST support for ACPI hotplug Shuah Khan
2012-05-09 18:44 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336664428.2581.21.camel@lorien2 \
--to=shuahkhan@gmail.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).