linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: lenb@kernel.org, linux-acpi@vger.kernel.org
Cc: bhelgaas@google.com, shuahkhan@gmail.com, liuj97@gmail.com,
	andi@firstfloor.org, linux-kernel@vger.kernel.org,
	Toshi Kani <toshi.kani@hp.com>
Subject: [PATCH v4 3/6] ACPI: Add _OST support for ACPI CPU hotplug
Date: Wed, 23 May 2012 20:25:21 -0600	[thread overview]
Message-ID: <1337826324-16802-4-git-send-email-toshi.kani@hp.com> (raw)
In-Reply-To: <1337826324-16802-1-git-send-email-toshi.kani@hp.com>

Changed acpi_processor_hotplug_notify() to call ACPI _OST method
when ACPI CPU hotplug operation has completed.

Signed-off-by: Toshi Kani <toshi.kani@hp.com>
---
 drivers/acpi/processor_driver.c |   28 ++++++++++++++++++++--------
 1 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
index 0734086..971c454 100644
--- a/drivers/acpi/processor_driver.c
+++ b/drivers/acpi/processor_driver.c
@@ -701,9 +701,9 @@ static void acpi_processor_hotplug_notify(acpi_handle handle,
 {
 	struct acpi_processor *pr;
 	struct acpi_device *device = NULL;
+	u32 ost_code = ACPI_OST_SC_NON_SPECIFIC_FAILURE; /* default */
 	int result;
 
-
 	switch (event) {
 	case ACPI_NOTIFY_BUS_CHECK:
 	case ACPI_NOTIFY_DEVICE_CHECK:
@@ -715,14 +715,18 @@ static void acpi_processor_hotplug_notify(acpi_handle handle,
 		if (!is_processor_present(handle))
 			break;
 
-		if (acpi_bus_get_device(handle, &device)) {
-			result = acpi_processor_device_add(handle, &device);
-			if (result)
-				printk(KERN_ERR PREFIX
-					    "Unable to add the device\n");
+		if (!acpi_bus_get_device(handle, &device))
+			break;
+
+		result = acpi_processor_device_add(handle, &device);
+		if (result) {
+			printk(KERN_ERR PREFIX "Unable to add the device\n");
 			break;
 		}
+
+		ost_code = ACPI_OST_SC_SUCCESS;
 		break;
+
 	case ACPI_NOTIFY_EJECT_REQUEST:
 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
 				  "received ACPI_NOTIFY_EJECT_REQUEST\n"));
@@ -736,15 +740,23 @@ static void acpi_processor_hotplug_notify(acpi_handle handle,
 		if (!pr) {
 			printk(KERN_ERR PREFIX
 				    "Driver data is NULL, dropping EJECT\n");
-			return;
+			break;
 		}
+
+		/* REVISIT: update when eject is supported */
+		ost_code = ACPI_OST_SC_EJECT_NOT_SUPPORTED;
 		break;
+
 	default:
 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
 				  "Unsupported event [0x%x]\n", event));
-		break;
+
+		/* non-hotplug event; possibly handled by other handler */
+		return;
 	}
 
+	/* Inform firmware that the hotplug operation has completed */
+	(void) acpi_evaluate_hotplug_ost(handle, event, ost_code, NULL);
 	return;
 }
 
-- 
1.7.7.6

  parent reply	other threads:[~2012-05-24  2:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24  2:25 [PATCH v4 0/6] ACPI: Add _OST support for ACPI hotplug Toshi Kani
2012-05-24  2:25 ` [PATCH v4 1/6] ACPI: Add an interface to evaluate _OST Toshi Kani
2012-05-24 18:09   ` Shuah Khan
2012-05-24 20:40     ` Toshi Kani
2012-05-24  2:25 ` [PATCH v4 2/6] ACPI: Add _OST support for sysfs eject Toshi Kani
2012-05-24  2:25 ` Toshi Kani [this message]
2012-05-24  2:25 ` [PATCH v4 4/6] ACPI: Add _OST support for ACPI memory hotplug Toshi Kani
2012-05-24 18:21   ` Shuah Khan
2012-05-24 20:25     ` Toshi Kani
2012-05-24  2:25 ` [PATCH v4 5/6] ACPI: Add _OST support for ACPI container hotplug Toshi Kani
2012-06-05  4:39   ` Yasuaki Ishimatsu
2012-06-05 15:36     ` Kani, Toshimitsu
2012-06-11  1:55       ` Yasuaki Ishimatsu
2012-06-11  7:12         ` Kani, Toshimitsu
2012-05-24  2:25 ` [PATCH v4 6/6] ACPI: Set hotplug _OST support bit to _OSC Toshi Kani
2012-05-24 18:27   ` Shuah Khan
2012-05-24 20:53     ` Toshi Kani
2012-05-24 17:34 ` [PATCH v4 0/6] ACPI: Add _OST support for ACPI hotplug Shuah Khan
2012-05-24 19:48   ` Toshi Kani
2012-05-29 22:27     ` Moore, Robert
2012-05-29 22:44       ` Shuah Khan
2012-05-29 23:43         ` Toshi Kani
2012-05-30  2:56           ` Moore, Robert
2012-05-30 14:11             ` Toshi Kani
2012-05-30 15:24     ` Shuah Khan
2012-05-30 17:19       ` Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337826324-16802-4-git-send-email-toshi.kani@hp.com \
    --to=toshi.kani@hp.com \
    --cc=andi@firstfloor.org \
    --cc=bhelgaas@google.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuj97@gmail.com \
    --cc=shuahkhan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).