From: "Xiao, Hui" <hui.xiao@linux.intel.com>
To: garyhade@us.ibm.com, tony.luck@intel.com, ying.huang@intel.com,
lenb@kernel.org, pluto@agmk.net, khali@linux-fr.org,
linux-acpi@vger.kernel.org
Cc: "Xiao, Hui" <hui.xiao@linux.intel.com>,
Chen Gong <gong.chen@linux.intel.com>
Subject: [RFC] ACPI, APEI: Fix incorrect bit width + offset check condition
Date: Wed, 13 Jun 2012 15:39:44 +0800 [thread overview]
Message-ID: <1339573184-3122-1-git-send-email-hui.xiao@linux.intel.com> (raw)
Fix the incorrect bit width + offset check condition in apei_check_gar()
function introduced by commit v3.3-5-g15afae6.
The bug caused regression on EINJ error injection with errors:
[Firmware Bug]: APEI: Invalid bit width + offset in GAR [0x1121a5000/64/0/3/0]
on a valid address region of:
- Register bit width: 64 bits
- Register bit offset: 0
- Access Size: 03 [DWord Access: 32]
Signed-off-by: Xiao, Hui <hui.xiao@linux.intel.com>
Signed-off-by: Chen Gong <gong.chen@linux.intel.com>
---
drivers/acpi/apei/apei-base.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c
index 5577762..95e07b2 100644
--- a/drivers/acpi/apei/apei-base.c
+++ b/drivers/acpi/apei/apei-base.c
@@ -586,9 +586,12 @@ static int apei_check_gar(struct acpi_generic_address *reg, u64 *paddr,
}
*access_bit_width = 1UL << (access_size_code + 2);
- if ((bit_width + bit_offset) > *access_bit_width) {
+ /* bit_width and bit_offset must be zero when addressing a data
+ * structure. So just check for non-zero case here */
+ if ((bit_width != 0 && *access_bit_width > bit_width) ||
+ bit_offset > *access_bit_width) {
pr_warning(FW_BUG APEI_PFX
- "Invalid bit width + offset in GAR [0x%llx/%u/%u/%u/%u]\n",
+ "Invalid bit width or offset in GAR [0x%llx/%u/%u/%u/%u]\n",
*paddr, bit_width, bit_offset, access_size_code,
space_id);
return -EINVAL;
--
1.7.3.4
next reply other threads:[~2012-06-13 8:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 7:39 Xiao, Hui [this message]
2012-06-13 8:46 ` [RFC] ACPI, APEI: Fix incorrect bit width + offset check condition Jean Delvare
2012-06-13 10:44 ` Xiao, Hui
2012-06-14 7:53 ` Jean Delvare
2012-06-14 21:49 ` Gary Hade
2012-06-13 17:45 ` Gary Hade
2012-06-14 6:14 ` Xiao, Hui
2012-06-14 8:09 ` Jean Delvare
2012-06-14 16:32 ` Gary Hade
2012-06-15 11:28 ` Xiao, Hui
2012-07-18 8:24 ` Chen Gong
2012-07-18 14:28 ` Jean Delvare
2012-07-19 0:37 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339573184-3122-1-git-send-email-hui.xiao@linux.intel.com \
--to=hui.xiao@linux.intel.com \
--cc=garyhade@us.ibm.com \
--cc=gong.chen@linux.intel.com \
--cc=khali@linux-fr.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=pluto@agmk.net \
--cc=tony.luck@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).