public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ACPI,APEI: Fixup parameter check for ACPI5 in EINJ
@ 2012-06-16  7:10 Chen Gong
  0 siblings, 0 replies; 2+ messages in thread
From: Chen Gong @ 2012-06-16  7:10 UTC (permalink / raw)
  To: linux-acpi; +Cc: lenb, tony.luck, Chen Gong

We need the same checks for target address in the trigger
code when using ACPI5 that we already have when using the
parameter mode of ACPI4.x.

Signed-off-by: Chen Gong <gong.chen@linux.intel.com>
Tested-by: Tony Luck <tony.luck@intel.com>
---
 drivers/acpi/apei/einj.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
index 8e17936..8d457b5 100644
--- a/drivers/acpi/apei/einj.c
+++ b/drivers/acpi/apei/einj.c
@@ -367,7 +367,7 @@ static int __einj_error_trigger(u64 trigger_paddr, u32 type,
 	 * This will cause resource conflict with regular memory.  So
 	 * remove it from trigger table resources.
 	 */
-	if (param_extension && (type & 0x0038) && param2) {
+	if ((param_extension || acpi5) && (type & 0x0038) && param2) {
 		struct apei_resources addr_resources;
 		apei_resources_init(&addr_resources);
 		trigger_param_region = einj_get_trigger_parameter_region(
-- 
1.7.10


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ACPI,APEI: Fixup parameter check for ACPI5 in EINJ
@ 2012-06-16  7:13 Chen Gong
  0 siblings, 0 replies; 2+ messages in thread
From: Chen Gong @ 2012-06-16  7:13 UTC (permalink / raw)
  To: linux-acpi; +Cc: lenb, tony.luck, Chen Gong

We need the same checks for target address in the trigger
code when using ACPI5 that we already have when using the
parameter mode of ACPI4.x.

Signed-off-by: Chen Gong <gong.chen@linux.intel.com>
Tested-by: Tony Luck <tony.luck@intel.com>
---
 drivers/acpi/apei/einj.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
index 8e17936..8d457b5 100644
--- a/drivers/acpi/apei/einj.c
+++ b/drivers/acpi/apei/einj.c
@@ -367,7 +367,7 @@ static int __einj_error_trigger(u64 trigger_paddr, u32 type,
 	 * This will cause resource conflict with regular memory.  So
 	 * remove it from trigger table resources.
 	 */
-	if (param_extension && (type & 0x0038) && param2) {
+	if ((param_extension || acpi5) && (type & 0x0038) && param2) {
 		struct apei_resources addr_resources;
 		apei_resources_init(&addr_resources);
 		trigger_param_region = einj_get_trigger_parameter_region(
-- 
1.7.10


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-16  7:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-16  7:10 [PATCH] ACPI,APEI: Fixup parameter check for ACPI5 in EINJ Chen Gong
  -- strict thread matches above, loose matches on Subject: below --
2012-06-16  7:13 Chen Gong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox