From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/4] ACPI: Add acpi_pr_() interfaces Date: Wed, 18 Jul 2012 14:54:12 -0700 Message-ID: <1342648452.2215.12.camel@joe2Laptop> References: <1342644027-19559-1-git-send-email-toshi.kani@hp.com> <1342644027-19559-2-git-send-email-toshi.kani@hp.com> <1342646502.2215.2.camel@joe2Laptop> <1342647682.3010.38.camel@misato.fc.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from perches-mx.perches.com ([206.117.179.246]:60602 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751954Ab2GRVyN (ORCPT ); Wed, 18 Jul 2012 17:54:13 -0400 In-Reply-To: <1342647682.3010.38.camel@misato.fc.hp.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Toshi Kani Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, isimatu.yasuaki@jp.fujitsu.com, liuj97@gmail.com, srivatsa.bhat@linux.vnet.ibm.com, prarit@redhat.com, imammedo@redhat.com, vijaymohan.pandarathil@hp.com On Wed, 2012-07-18 at 15:41 -0600, Toshi Kani wrote: > On Wed, 2012-07-18 at 14:21 -0700, Joe Perches wrote: > > On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote: > > > This patch introduces acpi_pr_(), where is a message > > > level such as err/warn/info, to support improved logging messages > > > for ACPI, esp. in hotplug operations. acpi_pr_() appends > > > "ACPI" prefix and ACPI object path to the messages. This improves > > > diagnostics in hotplug operations since it identifies an object that > > > caused an issue in a log file. [] > > I'd be tempted to instead make the calls more like > > other _ uses and rename these to > > acpi_ and change the existing acpi_info to > > another name. [] > I agree with you. Unfortunately, the ACPI CA (ACPI FW interpreter) > already uses them for its internal-use as follows, so I needed to come > up with some other name... Hence, acpi_pr_. > > /* > * Error reporting. Callers module and line number are inserted by AE_INFO, > * the plist contains a set of parens to allow variable-length lists. > * These macros are used for both the debug and non-debug versions of the code. > */ > #define ACPI_INFO(plist) acpi_info plist > #define ACPI_WARNING(plist) acpi_warning plist > #define ACPI_EXCEPTION(plist) acpi_exception plist > #define ACPI_ERROR(plist) acpi_error plist > #define ACPI_DEBUG_OBJECT(obj,l,i) acpi_ex_do_debug_object(obj,l,i) I wouldn't have a problem renaming a few of those to something like: #define ACPI_INFO(plist) acpi_old_info plist #define ACPI_WARNING(plist) acpi_old_warning plist #define ACPI_ERROR(plist) acpi_old_error plist The acpi folk might though. > > Other than that, seems fine to me. > Great! Can I consider it as Ack? :) Fix the kfree first. I rarely ack stuff as other people generally have to pick up the changes and I think acks are overrated. cheers, Joe