From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v2 1/4] ACPI: Add acpi_pr_() interfaces Date: Wed, 25 Jul 2012 00:06:57 -0700 Message-ID: <1343200017.30161.3.camel@joe2Laptop> References: <1342803256-17514-1-git-send-email-toshi.kani@hp.com> <1342803256-17514-2-git-send-email-toshi.kani@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from perches-mx.perches.com ([206.117.179.246]:51430 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751858Ab2GYHG6 (ORCPT ); Wed, 25 Jul 2012 03:06:58 -0400 In-Reply-To: <1342803256-17514-2-git-send-email-toshi.kani@hp.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Toshi Kani Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, isimatu.yasuaki@jp.fujitsu.com, liuj97@gmail.com, srivatsa.bhat@linux.vnet.ibm.com, prarit@redhat.com, imammedo@redhat.com, vijaymohan.pandarathil@hp.com On Fri, 2012-07-20 at 10:54 -0600, Toshi Kani wrote: > This patch introduces acpi_pr_(), where is a message > level such as err/warn/info, to support improved logging messages > for ACPI, esp. in hotplug operations. acpi_pr_() appends > "ACPI" prefix and ACPI object path to the messages. This improves > diagnostics in hotplug operations since it identifies an object that > caused an issue in a log file. trivia: > diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c [] > @@ -454,3 +454,37 @@ acpi_evaluate_hotplug_ost(acpi_handle handle, u32 source_event, [] > + char *path; const ? > diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h [] > @@ -85,6 +85,26 @@ struct acpi_pld { [] > +#define acpi_pr_debug(handle, fmt, ...) \ > + acpi_printk(KERN_DEBUG, handle, fmt, ##__VA_ARGS__) Might be nicer if this somehow had a dynamic debug mechanism too.