From: Joe Perches <joe@perches.com>
To: Toshi Kani <toshi.kani@hp.com>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, bhelgaas@google.com,
isimatu.yasuaki@jp.fujitsu.com, liuj97@gmail.com,
srivatsa.bhat@linux.vnet.ibm.com, prarit@redhat.com,
imammedo@redhat.com, vijaymohan.pandarathil@hp.com
Subject: Re: [PATCH v2 1/4] ACPI: Add acpi_pr_<level>() interfaces
Date: Wed, 25 Jul 2012 11:11:49 -0700 [thread overview]
Message-ID: <1343239909.7045.2.camel@joe2Laptop> (raw)
In-Reply-To: <1343238829.3010.394.camel@misato.fc.hp.com>
On Wed, 2012-07-25 at 11:53 -0600, Toshi Kani wrote:
> On Wed, 2012-07-25 at 00:06 -0700, Joe Perches wrote:
> > On Fri, 2012-07-20 at 10:54 -0600, Toshi Kani wrote:
> > > This patch introduces acpi_pr_<level>(), where <level> is a message
> > > level such as err/warn/info, to support improved logging messages
> > > for ACPI, esp. in hotplug operations. acpi_pr_<level>() appends
> > > "ACPI" prefix and ACPI object path to the messages. This improves
> > > diagnostics in hotplug operations since it identifies an object that
> > > caused an issue in a log file.
>
> Hi Joe,
>
> Thanks for reviewing!
>
> > trivia:
>
> Did you mean to say something more on this? Just checking...
No. I just intended to note that the comments that followed
weren't particularly important nor should it really stop the
patch from being applied if you didn't want to update it.
cheers, Joe
next prev parent reply other threads:[~2012-07-25 18:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 16:54 [PATCH v2 0/4] ACPI: hotplug messages improvement Toshi Kani
2012-07-20 16:54 ` [PATCH v2 1/4] ACPI: Add acpi_pr_<level>() interfaces Toshi Kani
2012-07-25 7:06 ` Joe Perches
2012-07-25 17:53 ` Toshi Kani
2012-07-25 18:11 ` Joe Perches [this message]
2012-07-25 18:30 ` Toshi Kani
2012-07-20 16:54 ` [PATCH v2 2/4] ACPI: Update CPU hotplug messages Toshi Kani
2012-07-20 16:54 ` [PATCH v2 3/4] ACPI: Update Memory " Toshi Kani
2012-07-20 16:54 ` [PATCH v2 4/4] ACPI: Update Container " Toshi Kani
2012-07-25 6:15 ` [PATCH v2 0/4] ACPI: hotplug messages improvement Pandarathil, Vijaymohan R
2012-07-25 15:31 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343239909.7045.2.camel@joe2Laptop \
--to=joe@perches.com \
--cc=bhelgaas@google.com \
--cc=imammedo@redhat.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=prarit@redhat.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=toshi.kani@hp.com \
--cc=vijaymohan.pandarathil@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).