From: Zhang Rui <rui.zhang@intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Matthew Garrett <mjg@redhat.com>, Len Brown <lenb@kernel.org>,
R Durgadoss <durgadoss.r@intel.com>,
Eduardo Valentin <eduardo.valentin@ti.com>,
Amit Kachhap <amit.kachhap@linaro.org>, Wei Ni <wni@nvidia.com>,
linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH RESEND 08/16] Thermal: Remove tc1/tc2 in generic thermal layer.
Date: Thu, 26 Jul 2012 10:23:08 +0800 [thread overview]
Message-ID: <1343269388.1682.401.camel@rui.sh.intel.com> (raw)
In-Reply-To: <201207252224.06694.rjw@sisk.pl>
On 三, 2012-07-25 at 22:24 +0200, Rafael J. Wysocki wrote:
> First, it would be good to write something about the motivation here.
>
> Second, I suppose that there are no users of the code in question who
> rely on the current behavior except for ACPI. If that is the case, it
> should be state in the changelog too, because that's an important piece
> of information for whoever wants to understand what's going on. If
> that is not the case, however, you should describe how your changes will
> affect the users in question, so that it's clear enough that no regressions
> will result from this change.
>
yep, but I think I should state this in the previous patch, when
introducing .get_trend() callback.
This patch just does some cleanups.
thanks,
rui
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-07-26 2:21 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 2:10 [PATCH RESEND 00/16] Thermal: generic thermal layer enhancement Zhang Rui
2012-07-25 2:10 ` [PATCH RESEND 01/16] Thermal: Make Thermal trip points writeable Zhang Rui
2012-07-25 3:18 ` Len Brown
2012-07-25 2:10 ` [PATCH RESEND 02/16] Thermal: Add Hysteresis attributes Zhang Rui
2012-07-25 3:19 ` Len Brown
2012-07-25 2:11 ` [PATCH RESEND 03/16] Thermal: Documentation update Zhang Rui
2012-07-25 2:11 ` [PATCH RESEND 04/16] Thermal: Introduce multiple cooling states support Zhang Rui
2012-07-25 20:06 ` Rafael J. Wysocki
2012-07-26 2:33 ` Zhang Rui
2012-07-25 2:11 ` [PATCH RESEND 05/16] Thermal: Introduce cooling states range support Zhang Rui
2012-07-25 20:08 ` Rafael J. Wysocki
2012-08-08 12:07 ` Valentin, Eduardo
2012-07-25 2:11 ` [PATCH RESEND 06/16] Thermal: set upper and lower limits Zhang Rui
2012-07-25 20:14 ` Rafael J. Wysocki
2012-08-08 12:50 ` Valentin, Eduardo
2012-07-25 2:11 ` [PATCH RESEND 07/16] Thermal: Introduce .get_trend() callback Zhang Rui
2012-07-25 20:19 ` Rafael J. Wysocki
2012-07-26 2:21 ` Zhang Rui
2012-07-25 2:11 ` [PATCH RESEND 08/16] Thermal: Remove tc1/tc2 in generic thermal layer Zhang Rui
2012-07-25 20:24 ` Rafael J. Wysocki
2012-07-26 2:23 ` Zhang Rui [this message]
2012-07-25 2:11 ` [PATCH RESEND 09/16] Thermal: Introduce thermal_zone_trip_update() Zhang Rui
2012-07-25 20:31 ` Rafael J. Wysocki
2012-07-26 2:25 ` Zhang Rui
2012-07-25 2:11 ` [PATCH RESEND 10/16] Thermal: rename structure thermal_cooling_device_instance to thermal_instance Zhang Rui
2012-07-25 20:32 ` Rafael J. Wysocki
2012-07-25 2:11 ` [PATCH RESEND 11/16] Thermal: Rename thermal_zone_device.cooling_devices Zhang Rui
2012-07-25 20:33 ` Rafael J. Wysocki
2012-07-25 2:11 ` [PATCH RESEND 12/16] Thermal: Rename thermal_instance.node to thermal_instance.tz_node Zhang Rui
2012-07-25 20:34 ` Rafael J. Wysocki
2012-07-25 2:11 ` [PATCH RESEND 13/16] Thermal: List thermal_instance in thermal_cooling_device Zhang Rui
2012-07-25 20:35 ` Rafael J. Wysocki
2012-07-25 2:11 ` [PATCH RESEND 14/16] Thermal: Introduce simple arbitrator for setting device cooling state Zhang Rui
2012-07-25 20:38 ` Rafael J. Wysocki
2012-07-25 2:11 ` [PATCH RESEND 15/16] Thermal: Unify the code for both active and passive cooling Zhang Rui
2012-07-25 20:41 ` Rafael J. Wysocki
2012-08-09 8:26 ` Valentin, Eduardo
2012-08-09 8:32 ` Zhang Rui
2012-07-25 2:11 ` [PATCH RESEND 16/16] Thermal: Introduce locking for cdev.thermal_instances list Zhang Rui
2012-07-25 18:54 ` Rafael J. Wysocki
2012-07-26 2:32 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343269388.1682.401.camel@rui.sh.intel.com \
--to=rui.zhang@intel.com \
--cc=amit.kachhap@linaro.org \
--cc=durgadoss.r@intel.com \
--cc=eduardo.valentin@ti.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=rjw@sisk.pl \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).