From: Zhang Rui <rui.zhang@intel.com>
To: Amit Kachhap <amit.kachhap@linaro.org>
Cc: linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Matthew Garrett <mjg@redhat.com>, Len Brown <lenb@kernel.org>,
R Durgadoss <durgadoss.r@intel.com>,
Eduardo Valentin <eduardo.valentin@intel.com>,
Wei Ni <wni@nvidia.com>
Subject: Re: [PATCH 09/16] Thermal: Introduce thermal_zone_trip_update()
Date: Thu, 26 Jul 2012 13:08:03 +0800 [thread overview]
Message-ID: <1343279283.1682.412.camel@rui.sh.intel.com> (raw)
In-Reply-To: <CAK44p20a6zKHLWhUeguL7ZZH+b55=ZYMv7KiA=q2LdcoDk05uQ@mail.gmail.com>
On 二, 2012-07-24 at 13:36 +0530, Amit Kachhap wrote:
> On 24 July 2012 12:41, Zhang Rui <rui.zhang@intel.com> wrote:
> > On 二, 2012-07-24 at 12:27 +0530, Amit Kachhap wrote:
> >>
> >>
> >> On 19 July 2012 12:01, Zhang Rui <rui.zhang@intel.com> wrote:
> >> This function is used to update the cooling state of
> >> all the cooling devices that are binded to an active trip
> >> point.
> >>
> >> This will be used for passive cooling as well, in the future
> >> patches.
> >> as both active and passive cooling can share the same
> >> algorithm,
> >> which is
> >>
> >> 1. if the temperature is higher than a trip point,
> >> a. if the trend is THERMAL_TREND_RAISING, use higher
> >> cooling
> >> state for this trip point
> >> b. if the trend is THERMAL_TREND_DROPPING, use lower
> >> cooling
> >> state for this trip point
> >>
> >> 2. if the temperature is lower than a trip point, use lower
> >> cooling state for this trip point.
> >>
> >> Hi Rui,
> >>
> >> Your patches looks useful.
> >> For my platform I need to have get_trend called even in the case when
> >> current temp is less than the trip point and then use
> >> THERMAL_TREND_DROPPING to actually lower the cooling state.
> >>
> > hmm, why?
> > in the current cooling algorithm, when the temperature is lower than the
> > trip point, the cooling state is decreased by 1 every time,
> > unconditionally, isn't this what you want?
>
> Basically the requirement is that I do not want to remove the cooling
> device when the temp just reaches below the trip point because this
> causes many throttling in this trip point so say I will remove cooling
> device when the temp is < (trip - 5) which can be done inside the new
> platform get_trend call.
>
As Durga is working on the thermal governor patches, I think that one
can handle this, right?
Currently, as I do not want to change the behavior of the current
drivers, ACPI passive cooling, etc, I did not use trend when the
temperature is lower than the trip point.
But anyway, if really needed, I can generate an incremental patch.
what do you think?
thanks,
rui
> Thanks,
> Amit D
> >
> > thanks,
> > rui
> >
> >> Thanks,
> >> Amit
> >>
> >>
> >> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> >> ---
> >> drivers/acpi/thermal.c | 7 +++-
> >> drivers/thermal/thermal_sys.c | 91
> >> +++++++++++++++++++++++++++++------------
> >> 2 files changed, 71 insertions(+), 27 deletions(-)
> >>
> >> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> >> index 73e335f..14c4879 100644
> >> --- a/drivers/acpi/thermal.c
> >> +++ b/drivers/acpi/thermal.c
> >> @@ -715,7 +715,12 @@ static int thermal_get_trend(struct
> >> thermal_zone_device *thermal,
> >> if (thermal_get_trip_type(thermal, trip, &type))
> >> return -EINVAL;
> >>
> >> - /* Only PASSIVE trip points need TREND */
> >> + if (type == THERMAL_TRIP_ACTIVE) {
> >> + /* aggressive active cooling */
> >> + *trend = THERMAL_TREND_RAISING;
> >> + return 0;
> >> + }
> >> +
> >> if (type != THERMAL_TRIP_PASSIVE)
> >> return -EINVAL;
> >>
> >> diff --git a/drivers/thermal/thermal_sys.c
> >> b/drivers/thermal/thermal_sys.c
> >> index 59af3b8..011faba 100644
> >> --- a/drivers/thermal/thermal_sys.c
> >> +++ b/drivers/thermal/thermal_sys.c
> >> @@ -1076,6 +1076,70 @@ void
> >> thermal_cooling_device_unregister(struct
> >> }
> >> EXPORT_SYMBOL(thermal_cooling_device_unregister);
> >>
> >> +/*
> >> + * Cooling algorithm for active trip points
> >> + *
> >> + * 1. if the temperature is higher than a trip point,
> >> + * a. if the trend is THERMAL_TREND_RAISING, use higher
> >> cooling
> >> + * state for this trip point
> >> + * b. if the trend is THERMAL_TREND_DROPPING, use lower
> >> cooling
> >> + * state for this trip point
> >> + *
> >> + * 2. if the temperature is lower than a trip point, use
> >> lower
> >> + * cooling state for this trip point
> >> + *
> >> + * Note that this behaves the same as the previous passive
> >> cooling
> >> + * algorithm.
> >> + */
> >> +
> >> +static void thermal_zone_trip_update(struct
> >> thermal_zone_device *tz,
> >> + int trip, long temp)
> >> +{
> >> + struct thermal_cooling_device_instance *instance;
> >> + struct thermal_cooling_device *cdev = NULL;
> >> + unsigned long cur_state, max_state;
> >> + long trip_temp;
> >> + enum thermal_trend trend;
> >> +
> >> + tz->ops->get_trip_temp(tz, trip, &trip_temp);
> >> +
> >> + if (temp >= trip_temp) {
> >> + thermal_get_trend(tz, trip, &trend);
> >> +
> >> + list_for_each_entry(instance,
> >> &tz->cooling_devices, node) {
> >> + if (instance->trip != trip)
> >> + continue;
> >> +
> >> + cdev = instance->cdev;
> >> +
> >> + cdev->ops->get_cur_state(cdev,
> >> &cur_state);
> >> + cdev->ops->get_max_state(cdev,
> >> &max_state);
> >> +
> >> + if (trend == THERMAL_TREND_RAISING) {
> >> + cur_state = cur_state <
> >> instance->upper ?
> >> + (cur_state + 1) :
> >> instance->upper;
> >> + } else if (trend ==
> >> THERMAL_TREND_DROPPING) {
> >> + cur_state = cur_state >
> >> instance->lower ?
> >> + (cur_state - 1) :
> >> instance->lower;
> >> + }
> >> + cdev->ops->set_cur_state(cdev,
> >> cur_state);
> >> + }
> >> + } else { /* below trip */
> >> + list_for_each_entry(instance,
> >> &tz->cooling_devices, node) {
> >> + if (instance->trip != trip)
> >> + continue;
> >> +
> >> + cdev = instance->cdev;
> >> + cdev->ops->get_cur_state(cdev,
> >> &cur_state);
> >> +
> >> + cur_state = cur_state >
> >> instance->lower ?
> >> + (cur_state - 1) :
> >> instance->lower;
> >> + cdev->ops->set_cur_state(cdev,
> >> cur_state);
> >> + }
> >> + }
> >> +
> >> + return;
> >> +}
> >> /**
> >> * thermal_zone_device_update - force an update of a thermal
> >> zone's state
> >> * @ttz: the thermal zone to update
> >> @@ -1086,9 +1150,6 @@ void thermal_zone_device_update(struct
> >> thermal_zone_device *tz)
> >> int count, ret = 0;
> >> long temp, trip_temp;
> >> enum thermal_trip_type trip_type;
> >> - struct thermal_cooling_device_instance *instance;
> >> - struct thermal_cooling_device *cdev;
> >> - unsigned long cur_state, max_state;
> >>
> >> mutex_lock(&tz->lock);
> >>
> >> @@ -1124,29 +1185,7 @@ void thermal_zone_device_update(struct
> >> thermal_zone_device *tz)
> >> tz->ops->notify(tz,
> >> count, trip_type);
> >> break;
> >> case THERMAL_TRIP_ACTIVE:
> >> - list_for_each_entry(instance,
> >> &tz->cooling_devices,
> >> - node) {
> >> - if (instance->trip != count)
> >> - continue;
> >> -
> >> - cdev = instance->cdev;
> >> -
> >> - cdev->ops->get_cur_state(cdev,
> >> &cur_state);
> >> - cdev->ops->get_max_state(cdev,
> >> &max_state);
> >> -
> >> - if (temp >= trip_temp)
> >> - cur_state =
> >> - cur_state <
> >> instance->upper ?
> >> - (cur_state +
> >> 1) :
> >> -
> >> instance->upper;
> >> - else
> >> - cur_state =
> >> - cur_state >
> >> instance->lower ?
> >> - (cur_state -
> >> 1) :
> >> -
> >> instance->lower;
> >> -
> >> - cdev->ops->set_cur_state(cdev,
> >> cur_state);
> >> - }
> >> + thermal_zone_trip_update(tz, count,
> >> temp);
> >> break;
> >> case THERMAL_TRIP_PASSIVE:
> >> if (temp >= trip_temp || tz->passive)
> >> --
> >> 1.7.9.5
> >>
> >>
> >
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-07-26 5:06 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 6:31 [PATCH 00/16] Thermal: generic thermal layer enhancement Zhang Rui
2012-07-19 6:31 ` [PATCH 01/16] Thermal: Make Thermal trip points writeable Zhang Rui
2012-07-19 10:35 ` R, Durgadoss
2012-07-19 19:38 ` Rafael J. Wysocki
2012-07-23 8:11 ` Zhang Rui
2012-07-19 20:27 ` Rafael J. Wysocki
2012-07-23 8:22 ` Zhang Rui
2012-07-23 10:25 ` Rafael J. Wysocki
2012-07-19 6:31 ` [PATCH 02/16] Thermal: Add Hysteresis attributes Zhang Rui
2012-07-19 10:40 ` R, Durgadoss
2012-07-19 20:00 ` Rafael J. Wysocki
2012-07-19 6:31 ` [PATCH 03/16] Thermal: Documentation update Zhang Rui
2012-07-19 10:51 ` R, Durgadoss
2012-07-23 8:36 ` Zhang Rui
2012-07-19 6:31 ` [PATCH 04/16] Thermal: Introduce multiple cooling states support Zhang Rui
2012-07-19 6:31 ` [PATCH 05/16] Thermal: Introduce cooling states range support Zhang Rui
2012-07-19 6:31 ` [PATCH 06/16] Thermal: set upper and lower limits Zhang Rui
2012-07-19 20:55 ` Rafael J. Wysocki
2012-07-23 8:45 ` Zhang Rui
2012-07-23 19:15 ` Rafael J. Wysocki
2012-07-19 6:31 ` [PATCH 07/16] Thermal: Introduce .get_trend() callback Zhang Rui
2012-07-19 21:13 ` Rafael J. Wysocki
2012-07-24 1:42 ` Zhang Rui
2012-07-24 9:22 ` Rafael J. Wysocki
2012-07-19 22:09 ` Jacob Pan
2012-07-20 9:53 ` Rafael J. Wysocki
2012-07-20 16:12 ` Jacob Pan
2012-07-19 6:31 ` [PATCH 08/16] Thermal: Remove tc1/tc2 in generic thermal layer Zhang Rui
2012-07-19 6:31 ` [PATCH 09/16] Thermal: Introduce thermal_zone_trip_update() Zhang Rui
2012-07-19 21:19 ` Rafael J. Wysocki
2012-07-24 1:47 ` Zhang Rui
2012-07-24 9:27 ` Rafael J. Wysocki
2012-07-25 1:38 ` Zhang Rui
2012-07-25 11:07 ` Rafael J. Wysocki
2012-07-26 0:49 ` Zhang Rui
[not found] ` <CAK44p21hNYGH4YkH5E+XK-pM2upingQbvm77WkJbttCRp6ZamQ@mail.gmail.com>
2012-07-24 7:11 ` Zhang Rui
2012-07-24 8:06 ` Amit Kachhap
2012-07-26 5:08 ` Zhang Rui [this message]
2012-07-26 6:01 ` R, Durgadoss
2012-07-24 7:57 ` Amit Kachhap
2012-07-19 6:31 ` [PATCH 10/16] Thermal: rename structure thermal_cooling_device_instance to thermal_instance Zhang Rui
2012-07-19 6:31 ` [PATCH 11/16] Thermal: Rename thermal_zone_device.cooling_devices to thermal_zone_device.instances Zhang Rui
2012-07-19 21:22 ` Rafael J. Wysocki
2012-07-24 1:48 ` Zhang Rui
2012-07-19 6:31 ` [PATCH 12/16] Thermal: Rename thermal_instance.node to thermal_instance.tz_node Zhang Rui
2012-07-19 6:31 ` [PATCH 13/16] Thermal: List thermal_instance in thermal_cooling_device Zhang Rui
2012-07-19 21:25 ` Rafael J. Wysocki
2012-07-24 1:48 ` Zhang Rui
2012-07-19 6:31 ` [PATCH 14/16] Thermal: Introduce simple arbitrator for setting device cooling state Zhang Rui
2012-07-19 21:39 ` Rafael J. Wysocki
2012-07-24 1:49 ` Zhang Rui
2012-07-19 6:31 ` [PATCH 15/16] Thermal: Unify the code for both active and passive cooling Zhang Rui
2012-07-19 6:31 ` [PATCH 16/16] Thermal: use plist instead of list Zhang Rui
2012-07-19 21:45 ` Rafael J. Wysocki
2012-07-24 2:13 ` Zhang Rui
2012-07-19 6:37 ` [PATCH 00/16] Thermal: generic thermal layer enhancement Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343279283.1682.412.camel@rui.sh.intel.com \
--to=rui.zhang@intel.com \
--cc=amit.kachhap@linaro.org \
--cc=durgadoss.r@intel.com \
--cc=eduardo.valentin@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=rjw@sisk.pl \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).