From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhang Rui Subject: Re: [PATCH/RFC] drm/radeon: ACPI: veto the keypress on ATIF events Date: Fri, 03 Aug 2012 09:40:35 +0800 Message-ID: <1343958035.1682.558.camel@rui.sh.intel.com> References: <20120729130644.GA12378@growl> <20120730202449.GA5600@growl> <20120731200520.GA5425@growl> <20120801134900.GA7909@growl> <1343868330.1682.502.camel@rui.sh.intel.com> <20120802134612.GA30802@growl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga11.intel.com ([192.55.52.93]:10030 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813Ab2HCBjW (ORCPT ); Thu, 2 Aug 2012 21:39:22 -0400 In-Reply-To: <20120802134612.GA30802@growl> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Luca Tettamanti Cc: Alex Deucher , airlied@gmail.com, dri-devel@lists.freedesktop.org, Alex Deucher , joeyli , linux-acpi@vger.kernel.org, Len Brown On =E5=9B=9B, 2012-08-02 at 15:46 +0200, Luca Tettamanti wrote: > On Thu, Aug 02, 2012 at 08:45:30AM +0800, Zhang Rui wrote: > > On =E4=B8=89, 2012-08-01 at 15:49 +0200, Luca Tettamanti wrote: > > > AMD ACPI interface may overload the standard event > > > ACPI_VIDEO_NOTIFY_PROBE (0x81) to signal AMD-specific events. In = such > > > cases we don't want to send the keypress (KEY_SWITCHVIDEOMODE) to= the > > > userspace because the user did not press the mode switch key (the > > > spurious keypress confuses the DE which usually changes the > > > display configuration and messes up a dual-screen setup). > > > This patch gives the radeon driver the chance to examine the even= t and > > > block the keypress if the event is an "AMD event". > > >=20 > > > Signed-off-by: Luca Tettamanti > > > --- > > > Any comment from ACPI front? > > >=20 > > it looks good to me. > > But I'm wondering if we can use the following code for ACPI part, w= hich > > looks cleaner. > > I know this may change the behavior of other events, but in theory,= we > > should not send any input event if we know something wrong in kerne= l. > >=20 > > what do you think? >=20 > I like it, it's cleaner. > I've split the patch in two pieces (one for video, the other for > radeon) and adopted your suggestion. >=20 Great. Acked-by: Zhang Rui hmm, who should take these two patches? and which tree the second patch is based on? thanks, rui -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html