linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Len Brown <lenb@kernel.org>, "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
	Aaron Lu <aaron.lwe@gmail.com>, Aaron Lu <aaron.lu@intel.com>
Subject: [PATCH] acpi: bus: handle power manageable but no _PSC/_PRx case
Date: Mon, 27 Aug 2012 15:38:46 +0800	[thread overview]
Message-ID: <1346053126-7646-1-git-send-email-aaron.lu@intel.com> (raw)

Currently, when we are trying to get the power state of an acpi device,
we will do the following:
If device is not power manageable, init its power state as its parent or
if it does not have a parent, init as D0;
If device is power manageable, evaluate _PSC and then refine with
acpi_power_get_inferred_state.

But there exist some devices with _PSx defined, but no _PSC or _PRx.
It is power manageable, but the above method to get power state does
not cover this case and its power state will be UNKNOWN(255).

So change the check of power manageable to whether _PSC and _PRx
defined.

Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
 drivers/acpi/bus.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 9628652..b564e6d 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -207,7 +207,8 @@ static int __acpi_bus_get_power(struct acpi_device *device, int *state)
 	if (!device || !state)
 		return -EINVAL;
 
-	if (!device->flags.power_manageable) {
+	if (!device->power.flags.explicit_get &&
+			!device->power.flags.power_resources) {
 		/* TBD: Non-recursive algorithm for walking up hierarchy. */
 		*state = device->parent ?
 			device->parent->power.state : ACPI_STATE_D0;
-- 
1.7.12.21.g871e293


             reply	other threads:[~2012-08-27  7:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-27  7:38 Aaron Lu [this message]
2012-09-06 21:45 ` [PATCH] acpi: bus: handle power manageable but no _PSC/_PRx case Rafael J. Wysocki
2012-09-06 21:53   ` Rafael J. Wysocki
2012-09-07  0:35     ` Aaron Lu
2012-09-07 11:46       ` Rafael J. Wysocki
2012-09-07 14:32         ` Aaron Lu
2012-09-07 18:32           ` Rafael J. Wysocki
2012-09-10  0:38             ` Aaron Lu
2012-09-10 19:48               ` Rafael J. Wysocki
2012-09-10 19:50               ` [PATCH] ACPI / PM: Infer parent power state from child if unknown Rafael J. Wysocki
2012-09-11  5:33                 ` Aaron Lu
2012-09-11 20:36                   ` Rafael J. Wysocki
2012-09-11 20:38                   ` [PATCH] ACPI / PM: Infer parent power state from child if unknown, v2 Rafael J. Wysocki
2012-09-12  6:59                     ` Aaron Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346053126-7646-1-git-send-email-aaron.lu@intel.com \
    --to=aaron.lu@intel.com \
    --cc=aaron.lwe@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).