[PATCH] Thermal: Provide option to choose default thermal governor

[PATCH] Thermal: Provide option to choose default thermal governor

[Durgadoss R]

This patch provides option to choose the default thermal
governor. If no option is provided, the step_wise
governor is selected by default.

Signed-off-by: Durgadoss R <durgadoss.r@intel.com>
---
 drivers/thermal/Kconfig |   33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 040c626..c0e11aa 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -71,3 +71,36 @@ config USER_SPACE
 	depends on THERMAL
 	help
 	  Enable this to let the user space manage the platform thermals.
+
+choice
+	prompt "Default Thermal governor"
+	depends on THERMAL
+	default THERMAL_DEFAULT_GOV_STEP_WISE
+	help
+	  This option sets which thermal governor shall be loaded at
+	  startup. If in doubt, select 'step_wise'.
+
+config THERMAL_DEFAULT_GOV_STEP_WISE
+	bool "step_wise"
+	select STEP_WISE
+	help
+	  Use the step_wise governor as default. This throttles the
+	  devices one step at a time.
+
+config THERMAL_DEFAULT_GOV_FAIR_SHARE
+	bool "fair_share"
+	select FAIR_SHARE
+	help
+	  Use the fair_share governor as default. This throttles the
+	  devices based on their 'contribution' to a zone. The
+	  contribution should be provided through platform data.
+
+config THERMAL_DEFAULT_GOV_USER_SPACE
+	bool "user_space"
+	select USER_SPACE
+	help
+	  Select this if you want to let the user space manage the
+	  platform thermals.
+endchoice
+
+
-- 
1.7.9.5

Re: [PATCH] Thermal: Provide option to choose default thermal governor

[Zhang Rui]

On 五, 2012-09-21 at 14:32 +0530, Durgadoss R wrote:
> This patch provides option to choose the default thermal
> governor. If no option is provided, the step_wise
> governor is selected by default.
> 
yep, I like this approach. will apply to my next tree.

thanks,
rui

> Signed-off-by: Durgadoss R <durgadoss.r@intel.com>
> ---
>  drivers/thermal/Kconfig |   33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 040c626..c0e11aa 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -71,3 +71,36 @@ config USER_SPACE
>  	depends on THERMAL
>  	help
>  	  Enable this to let the user space manage the platform thermals.
> +
> +choice
> +	prompt "Default Thermal governor"
> +	depends on THERMAL
> +	default THERMAL_DEFAULT_GOV_STEP_WISE
> +	help
> +	  This option sets which thermal governor shall be loaded at
> +	  startup. If in doubt, select 'step_wise'.
> +
> +config THERMAL_DEFAULT_GOV_STEP_WISE
> +	bool "step_wise"
> +	select STEP_WISE
> +	help
> +	  Use the step_wise governor as default. This throttles the
> +	  devices one step at a time.
> +
> +config THERMAL_DEFAULT_GOV_FAIR_SHARE
> +	bool "fair_share"
> +	select FAIR_SHARE
> +	help
> +	  Use the fair_share governor as default. This throttles the
> +	  devices based on their 'contribution' to a zone. The
> +	  contribution should be provided through platform data.
> +
> +config THERMAL_DEFAULT_GOV_USER_SPACE
> +	bool "user_space"
> +	select USER_SPACE
> +	help
> +	  Select this if you want to let the user space manage the
> +	  platform thermals.
> +endchoice
> +
> +


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] Thermal: Provide option to choose default thermal governor

[R, Durgadoss]

Hi Rui,

> -----Original Message-----
> From: Zhang, Rui
> Sent: Monday, September 24, 2012 11:10 AM
> To: R, Durgadoss
> Cc: lenb@kernel.org; linux-acpi@vger.kernel.org
> Subject: Re: [PATCH] Thermal: Provide option to choose default thermal
> governor
> 
> On 五, 2012-09-21 at 14:32 +0530, Durgadoss R wrote:
> > This patch provides option to choose the default thermal
> > governor. If no option is provided, the step_wise
> > governor is selected by default.
> >
> yep, I like this approach. will apply to my next tree.

That’s great.. Thanks Rui.
In this case, I believe you are taking the v4 of the 15 patches,
and this one on top of them.

Meanwhile, I will fix the minor comments on patches 4 and 7
and submit separate patches, hopefully by this week.

Thanks,
Durga

RE: [PATCH] Thermal: Provide option to choose default thermal governor

[Zhang Rui]

On 一, 2012-09-24 at 00:16 -0600, R, Durgadoss wrote:
> Hi Rui,
> 
> > -----Original Message-----
> > From: Zhang, Rui
> > Sent: Monday, September 24, 2012 11:10 AM
> > To: R, Durgadoss
> > Cc: lenb@kernel.org; linux-acpi@vger.kernel.org
> > Subject: Re: [PATCH] Thermal: Provide option to choose default thermal
> > governor
> > 
> > On 五, 2012-09-21 at 14:32 +0530, Durgadoss R wrote:
> > > This patch provides option to choose the default thermal
> > > governor. If no option is provided, the step_wise
> > > governor is selected by default.
> > >
> > yep, I like this approach. will apply to my next tree.
> 
> That’s great.. Thanks Rui.
> In this case, I believe you are taking the v4 of the 15 patches,
> and this one on top of them.
> 
yep, all of them have been applied to my next branch.

> Meanwhile, I will fix the minor comments on patches 4 and 7
> and submit separate patches, hopefully by this week.
> 
> Thanks,
> Durga


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html