From: Cyril Roelandt <tipecaml@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-acpi@vger.kernel.org, rjw@sisk.pl, lenb@kernel.org,
kernel-janitors@vger.kernel.org,
Cyril Roelandt <tipecaml@gmail.com>
Subject: [PATCH] acpi_system_write_wakeup_device(): fix error check for unsigned variable.
Date: Sat, 17 Nov 2012 02:54:23 +0100 [thread overview]
Message-ID: <1353117263-6957-1-git-send-email-tipecaml@gmail.com> (raw)
The LEN variable is unsigned, therefore checking whether it is less than 0 is
useless.
Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
---
drivers/acpi/proc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c
index 27adb09..37871a7 100644
--- a/drivers/acpi/proc.c
+++ b/drivers/acpi/proc.c
@@ -366,8 +366,6 @@ acpi_system_write_wakeup_device(struct file *file,
if (len > 4)
len = 4;
- if (len < 0)
- return -EFAULT;
if (copy_from_user(strbuf, buffer, len))
return -EFAULT;
--
1.7.10.4
next reply other threads:[~2012-11-17 2:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 1:54 Cyril Roelandt [this message]
2012-11-21 0:44 ` [PATCH] acpi_system_write_wakeup_device(): fix error check for unsigned variable Rafael J. Wysocki
2012-11-22 0:05 ` Cyril Roelandt
2012-11-22 0:23 ` Rafael J. Wysocki
2012-11-22 0:30 ` Cyril Roelandt
2012-11-22 0:34 ` [PATCH v2] " Cyril Roelandt
2012-11-22 22:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353117263-6957-1-git-send-email-tipecaml@gmail.com \
--to=tipecaml@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).