From: Toshi Kani <toshi.kani@hp.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Len Brown <lenb@kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH] ACPI: Remove useless type argument of driver .remove() operation
Date: Tue, 22 Jan 2013 14:24:27 -0700 [thread overview]
Message-ID: <1358889867.14145.354.camel@misato.fc.hp.com> (raw)
In-Reply-To: <1518653.CUpDmbmCI3@vostro.rjw.lan>
On Sun, 2013-01-20 at 23:04 +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The second argument of ACPI driver .remove() operation is only used
> by the ACPI processor driver and the value passed to that driver
> through it is always available from the given struct acpi_device
> object's removal_type field. For this reason, the second ACPI driver
> .remove() argument is in fact useless, so drop it.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Thanks for the clean-up! It looks good.
Acked-by: Toshi Kani <toshi.kani@hp.com>
-Toshi
next prev parent reply other threads:[~2013-01-22 21:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 22:04 [PATCH] ACPI: Remove useless type argument of driver .remove() operation Rafael J. Wysocki
2013-01-20 22:06 ` Rafael J. Wysocki
2013-01-22 21:54 ` Yinghai Lu
2013-01-22 22:03 ` Rafael J. Wysocki
2013-01-22 22:25 ` [PATCH] ACPI: Drop device start operation that is not used Rafael J. Wysocki
2013-01-22 22:14 ` Toshi Kani
2013-01-22 22:20 ` Yinghai Lu
2013-01-21 16:08 ` [PATCH] ACPI: Remove useless type argument of driver .remove() operation Jiang Liu
2013-01-21 22:46 ` Rafael J. Wysocki
2013-01-22 21:24 ` Toshi Kani [this message]
2013-01-22 22:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358889867.14145.354.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@sisk.pl \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox