* [PATCH 0/2] Fix section mismatch caused by node offline code.
@ 2013-01-24 9:38 Tang Chen
2013-01-24 9:38 ` [PATCH 1/2] cpu_hotplug: Remove __cpuinitdata declaration of __apicid_to_node[] Tang Chen
2013-01-24 9:38 ` [PATCH 2/2] cpu-hotplug,memory-hotplug: Remove __cpuinit declaration of numa_clear_node() Tang Chen
0 siblings, 2 replies; 3+ messages in thread
From: Tang Chen @ 2013-01-24 9:38 UTC (permalink / raw)
To: akpm, rjw, len.brown, mingo, tglx, minchan.kim, rientjes, benh,
paulus, cl, kosaki.motohiro, isimatu.yasuaki, wujianguo, wency,
hpa, linfeng, laijs, mgorman, yinghai, glommer, jiang.liu,
julian.calaby, sfr, guz.fnst
Cc: x86, linux-mm, linux-kernel, linuxppc-dev, linux-acpi
Since node offline code uses __apicid_to_node[] and numa_clear_node(),
they are no longer init data or function. So do not declare them as
__cpuinitdata or __cpuinit.
Tang Chen (2):
cpu_hotplug: Remove __cpuinitdata declaration of __apicid_to_node[].
cpu-hotplug,memory-hotplug: Remove __cpuinit declaration of
numa_clear_node().
arch/x86/mm/numa.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] cpu_hotplug: Remove __cpuinitdata declaration of __apicid_to_node[].
2013-01-24 9:38 [PATCH 0/2] Fix section mismatch caused by node offline code Tang Chen
@ 2013-01-24 9:38 ` Tang Chen
2013-01-24 9:38 ` [PATCH 2/2] cpu-hotplug,memory-hotplug: Remove __cpuinit declaration of numa_clear_node() Tang Chen
1 sibling, 0 replies; 3+ messages in thread
From: Tang Chen @ 2013-01-24 9:38 UTC (permalink / raw)
To: akpm, rjw, len.brown, mingo, tglx, minchan.kim, rientjes, benh,
paulus, cl, kosaki.motohiro, isimatu.yasuaki, wujianguo, wency,
hpa, linfeng, laijs, mgorman, yinghai, glommer, jiang.liu,
julian.calaby, sfr, guz.fnst
Cc: x86, linux-mm, linux-kernel, linuxppc-dev, linux-acpi
__apicid_to_node[] will be used by acpi_unmap_lsapic() when we do
node hotplug. So it is no longer an init data. Do not declare
__apicid_to_node[] as a __cpuinitdata, otherwise it will cause
section mismatch warning when compiling.
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
arch/x86/mm/numa.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
index 9b31ed5..0624c85 100644
--- a/arch/x86/mm/numa.c
+++ b/arch/x86/mm/numa.c
@@ -56,7 +56,7 @@ early_param("numa", numa_setup);
/*
* apicid, cpu, node mappings
*/
-s16 __apicid_to_node[MAX_LOCAL_APIC] __cpuinitdata = {
+s16 __apicid_to_node[MAX_LOCAL_APIC] = {
[0 ... MAX_LOCAL_APIC-1] = NUMA_NO_NODE
};
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] cpu-hotplug,memory-hotplug: Remove __cpuinit declaration of numa_clear_node().
2013-01-24 9:38 [PATCH 0/2] Fix section mismatch caused by node offline code Tang Chen
2013-01-24 9:38 ` [PATCH 1/2] cpu_hotplug: Remove __cpuinitdata declaration of __apicid_to_node[] Tang Chen
@ 2013-01-24 9:38 ` Tang Chen
1 sibling, 0 replies; 3+ messages in thread
From: Tang Chen @ 2013-01-24 9:38 UTC (permalink / raw)
To: akpm, rjw, len.brown, mingo, tglx, minchan.kim, rientjes, benh,
paulus, cl, kosaki.motohiro, isimatu.yasuaki, wujianguo, wency,
hpa, linfeng, laijs, mgorman, yinghai, glommer, jiang.liu,
julian.calaby, sfr, guz.fnst
Cc: x86, linux-mm, linux-kernel, linuxppc-dev, linux-acpi
numa_clear_node() will be used by check_and_unmap_cpu_on_node()
when we do node hotplug. So it is no longer a __cpuinit function.
Do not declare it as a __cpuinit function, otherwise it will cause
section mismatch warning when compiling.
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
arch/x86/mm/numa.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
index 0624c85..6864b08 100644
--- a/arch/x86/mm/numa.c
+++ b/arch/x86/mm/numa.c
@@ -100,7 +100,7 @@ void __cpuinit numa_set_node(int cpu, int node)
set_cpu_numa_node(cpu, node);
}
-void __cpuinit numa_clear_node(int cpu)
+void numa_clear_node(int cpu)
{
numa_set_node(cpu, NUMA_NO_NODE);
}
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-24 9:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-24 9:38 [PATCH 0/2] Fix section mismatch caused by node offline code Tang Chen
2013-01-24 9:38 ` [PATCH 1/2] cpu_hotplug: Remove __cpuinitdata declaration of __apicid_to_node[] Tang Chen
2013-01-24 9:38 ` [PATCH 2/2] cpu-hotplug,memory-hotplug: Remove __cpuinit declaration of numa_clear_node() Tang Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).