From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH] ACPI: suppress compiler warnings
Date: Mon, 11 Mar 2013 11:20:37 +0200 [thread overview]
Message-ID: <1362993637.28241.179.camel@smile> (raw)
In-Reply-To: <2201683.kMNYfgVRi1@vostro.rjw.lan>
On Mon, 2013-03-11 at 04:31 +0100, Rafael J. Wysocki wrote:
> On Friday, March 08, 2013 03:23:11 PM Andy Shevchenko wrote:
> > This patch fixes following compiler warnings:
> >
> > drivers/acpi/csrt.c:135:116: warning: no previous prototype for ‘acpi_csrt_init’ [-Wmissing-prototypes]
> >
> > drivers/acpi/container.c:183:116: warning: no previous prototype for ‘acpi_container_init’ [-Wmissing-prototypes]
> >
> > drivers/pci/pcie/portdrv_acpi.c:34:5: warning: no previous prototype for ‘pcie_port_acpi_setup’ [-Wmissing-prototypes]
> >
> > drivers/acpi/battery.c:149:52: warning: no previous prototype for ‘acpi_battery_present’ [-Wmissing-prototypes]
> >
> > drivers/acpi/button.c:220:5: warning: no previous prototype for ‘acpi_lid_notifier_register’ [-Wmissing-prototypes]
> > drivers/acpi/button.c:226:5: warning: no previous prototype for ‘acpi_lid_notifier_unregister’ [-Wmissing-prototypes]
> > drivers/acpi/button.c:232:5: warning: no previous prototype for ‘acpi_lid_open’ [-Wmissing-prototypes]
> >
> > drivers/acpi/processor_throttling.c: In function ‘acpi_processor_throttling_init’:
> > drivers/acpi/processor_throttling.c:216:40: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Please split this into separate per-file patches.
Done.
> Also it would be good to know what config options are triggering the warnings
> in each case.
You mean 'compiler option', do you?
Anyway, please, review patch v2 series.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-03-11 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 13:23 [PATCH] ACPI: suppress compiler warnings Andy Shevchenko
2013-03-11 3:31 ` Rafael J. Wysocki
2013-03-11 9:20 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362993637.28241.179.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox