From: Linn Crosetto <linn@hp.com>
To: rjw@sisk.pl, robert.moore@intel.com, ming.m.lin@intel.com,
lv.zheng@intel.com, linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Linn Crosetto <linn@hp.com>
Subject: [PATCH] acpi: remove length check for large registers
Date: Fri, 15 Mar 2013 13:56:07 -0600 [thread overview]
Message-ID: <1363377367-12813-1-git-send-email-linn@hp.com> (raw)
The legacy bit width field in the Generic Address Structure is 1 byte,
limiting the reportable register width to 255 bits. Larger registers
will cause a length mismatch warning to be printed in
acpi_tb_validate_fadt().
To avoid the warning, disable the length mismatch check for registers
larger than 255 bits.
Signed-off-by: Linn Crosetto <linn@hp.com>
---
drivers/acpi/acpica/tbfadt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/acpica/tbfadt.c b/drivers/acpi/acpica/tbfadt.c
index 74181bf..e87abcd 100644
--- a/drivers/acpi/acpica/tbfadt.c
+++ b/drivers/acpi/acpica/tbfadt.c
@@ -561,6 +561,7 @@ static void acpi_tb_validate_fadt(void)
* legacy length field and the corresponding 64-bit X length field.
*/
if (address64->address &&
+ ACPI_MUL_8(length) <= ACPI_UINT8_MAX &&
(address64->bit_width != ACPI_MUL_8(length))) {
ACPI_BIOS_WARNING((AE_INFO,
"32/64X length mismatch in FADT/%s: %u/%u",
--
1.7.11.3
next reply other threads:[~2013-03-15 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 19:56 Linn Crosetto [this message]
2013-03-15 20:50 ` [PATCH] acpi: remove length check for large registers Moore, Robert
2013-03-15 21:18 ` Linn Crosetto
2013-03-19 18:48 ` Moore, Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363377367-12813-1-git-send-email-linn@hp.com \
--to=linn@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=ming.m.lin@intel.com \
--cc=rjw@sisk.pl \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox