From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: [PATCH 1/2] ACPI / LPSS: Make condition local to lpt_register_clock_device Date: Wed, 20 Mar 2013 14:14:29 +0200 Message-ID: <1363781670-28775-1-git-send-email-andriy.shevchenko@linux.intel.com> Return-path: Received: from mga11.intel.com ([192.55.52.93]:37080 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756226Ab3CTMPB (ORCPT ); Wed, 20 Mar 2013 08:15:01 -0400 Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Mika Westerberg Cc: Andy Shevchenko It seems more logical to have the check of lpss_clk_dev variable in lpt_register_clock_device() because last one actually assignes the variable. Signed-off-by: Andy Shevchenko --- drivers/acpi/acpi_lpss.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c index c87db0e..c695841 100644 --- a/drivers/acpi/acpi_lpss.c +++ b/drivers/acpi/acpi_lpss.c @@ -84,6 +84,9 @@ static struct platform_device *lpss_clk_dev; static inline void lpt_register_clock_device(void) { + if (lpss_clk_dev) + return; + lpss_clk_dev = platform_device_register_simple("clk-lpt", -1, NULL, 0); } @@ -92,8 +95,7 @@ static int register_device_clock(struct acpi_device *adev, { const struct lpss_device_desc *dev_desc = pdata->dev_desc; - if (!lpss_clk_dev) - lpt_register_clock_device(); + lpt_register_clock_device(); if (!dev_desc->clk_parent || !pdata->mmio_base || pdata->mmio_size < dev_desc->prv_offset + LPSS_CLK_SIZE) -- 1.8.2.rc0.22.gb3600c3