From: Betty Dall <betty.dall@hp.com>
To: rjw@sisk.pl, bhelgaas@google.com
Cc: ying.huang@intel.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Betty Dall <betty.dall@hp.com>
Subject: [PATCH 1/3] PCI/AER: Fix incorrect return from aer_hest_parse()
Date: Tue, 28 May 2013 12:48:47 -0600 [thread overview]
Message-ID: <1369766929-4386-2-git-send-email-betty.dall@hp.com> (raw)
In-Reply-To: <1369766929-4386-1-git-send-email-betty.dall@hp.com>
The function aer_hest_parse() is called to determine if the given
PCI device is firmware first or not. The code loops through each
section of the HEST table to look for a match. The bug is that
the function always returns whether the last HEST section is firmware
first. The fix stops the iteration once the info.firmware_first
variable is set. This is similar to how the function aer_hest_parse_aff()
stops the iteration.
Signed-off-by: Betty Dall <betty.dall@hp.com>
---
drivers/pci/pcie/aer/aerdrv_acpi.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/pcie/aer/aerdrv_acpi.c b/drivers/pci/pcie/aer/aerdrv_acpi.c
index 5194a7d..39b8671 100644
--- a/drivers/pci/pcie/aer/aerdrv_acpi.c
+++ b/drivers/pci/pcie/aer/aerdrv_acpi.c
@@ -42,6 +42,9 @@ static int aer_hest_parse(struct acpi_hest_header *hest_hdr, void *data)
u8 bridge = 0;
int ff = 0;
+ if (info->firmware_first)
+ return 0;
+
switch (hest_hdr->type) {
case ACPI_HEST_TYPE_AER_ROOT_PORT:
pcie_type = PCI_EXP_TYPE_ROOT_PORT;
next prev parent reply other threads:[~2013-05-28 18:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 18:48 [PATCH 0/3] PCI/ACPI: Fix firmware first error recovery with root port in reset Betty Dall
2013-05-28 18:48 ` Betty Dall [this message]
2013-05-28 18:48 ` [PATCH 2/3] ACPI/APEI: Force fatal AER severity when bus has been reset Betty Dall
2013-05-29 15:42 ` Pearson, Greg
2013-05-29 16:16 ` Betty Dall
2013-05-28 18:48 ` [PATCH 3/3] PCI/AER: Provide reset_link for firmware first root port Betty Dall
2013-05-29 15:42 ` Pearson, Greg
2013-05-29 16:16 ` Betty Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369766929-4386-2-git-send-email-betty.dall@hp.com \
--to=betty.dall@hp.com \
--cc=bhelgaas@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox