From: Jiang Liu <liuj97@gmail.com>
To: "Rafael J . Wysocki" <rjw@sisk.pl>
Cc: liuj97@gmail.com, Jiang Liu <jiang.liu@huawei.com>,
Yijing Wang <wangyijing@huawei.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Len Brown <lenb@kernel.org>
Subject: [PATCH v3 04/10] ACPI, DOCK: simplify implementation of dock_create_acpi_device()
Date: Sat, 29 Jun 2013 00:24:37 +0800 [thread overview]
Message-ID: <1372436683-31711-5-git-send-email-liuj97@gmail.com> (raw)
In-Reply-To: <1372436683-31711-1-git-send-email-liuj97@gmail.com>
From: Jiang Liu <jiang.liu@huawei.com>
The return value of dock_create_acpi_device() is not used at all,
so change the signature to return void and simplify implementation.
Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Cc: Len Brown <lenb@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/acpi/dock.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index 8c4214d..22183c4 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -351,10 +351,8 @@ static int dock_present(struct dock_station *ds)
* handle if one does not exist already. This should cause
* acpi to scan for drivers for the given devices, and call
* matching driver's add routine.
- *
- * Returns a pointer to the acpi_device corresponding to the handle.
*/
-static struct acpi_device * dock_create_acpi_device(acpi_handle handle)
+static void dock_create_acpi_device(acpi_handle handle)
{
struct acpi_device *device;
int ret;
@@ -367,10 +365,7 @@ static struct acpi_device * dock_create_acpi_device(acpi_handle handle)
ret = acpi_bus_scan(handle);
if (ret)
pr_debug("error adding bus, %x\n", -ret);
-
- acpi_bus_get_device(handle, &device);
}
- return device;
}
/**
--
1.8.1.2
next prev parent reply other threads:[~2013-06-28 16:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 16:24 [PATCH v3 00/10] minor improvements for ACPI dock and acpiphp drivers Jiang Liu
2013-06-28 16:24 ` [PATCH v3 01/10] ACPI, DOCK: avoid initializing acpi_dock_notifier_list multiple times Jiang Liu
2013-06-28 16:24 ` [PATCH v3 02/10] ACPI, DOCK: kill redundant spin lock in dock station object Jiang Liu
2013-06-28 16:24 ` [PATCH v3 03/10] ACPI, DOCK: mark initialization functions with __init Jiang Liu
2013-06-28 16:24 ` Jiang Liu [this message]
2013-06-28 16:24 ` [PATCH v3 05/10] ACPI: introduce helper function acpi_has_method() Jiang Liu
2013-06-28 16:24 ` [PATCH v3 06/10] ACPI: introduce helper function acpi_execute_simple_method() Jiang Liu
2013-06-28 16:24 ` [PATCH v3 07/10] ACPI: introduce two helper functions to simplify code Jiang Liu
2013-06-28 16:24 ` [PATCH v3 08/10] ACPI: change acpi_[bay|dock]_match() in scan.c as global functions Jiang Liu
2013-06-28 16:24 ` [PATCH v3 09/10] ACPI: simplify dock driver with new helper functions Jiang Liu
2013-06-28 16:24 ` [PATCH v3 10/10] ACPI: simplify acpiphp " Jiang Liu
2013-06-28 17:20 ` Bjorn Helgaas
2013-06-28 18:42 ` Rafael J. Wysocki
2013-06-28 18:42 ` [PATCH v3 00/10] minor improvements for ACPI dock and acpiphp drivers Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372436683-31711-5-git-send-email-liuj97@gmail.com \
--to=liuj97@gmail.com \
--cc=jiang.liu@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).