From: Toshi Kani <toshi.kani@hp.com>
To: rjw@sisk.pl
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Toshi Kani <toshi.kani@hp.com>
Subject: [PATCH] ACPI / memhotplug: Fix a stale pointer in error path
Date: Wed, 10 Jul 2013 10:47:13 -0600 [thread overview]
Message-ID: <1373474833-14047-1-git-send-email-toshi.kani@hp.com> (raw)
device->driver_data needs to be cleared when releasing its data,
mem_device, in an error path of acpi_memory_device_add().
Signed-off-by: Toshi Kani <toshi.kani@hp.com>
---
drivers/acpi/acpi_memhotplug.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index c711d11..999adb5 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -323,6 +323,7 @@ static int acpi_memory_device_add(struct acpi_device *device,
/* Get the range from the _CRS */
result = acpi_memory_get_device_resources(mem_device);
if (result) {
+ device->driver_data = NULL;
kfree(mem_device);
return result;
}
next reply other threads:[~2013-07-10 16:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 16:47 Toshi Kani [this message]
2013-07-12 0:24 ` [PATCH] ACPI / memhotplug: Fix a stale pointer in error path Yasuaki Ishimatsu
2013-07-12 14:51 ` Toshi Kani
2013-07-12 20:42 ` Rafael J. Wysocki
2013-07-12 21:01 ` Toshi Kani
2013-07-12 21:13 ` Rafael J. Wysocki
2013-07-12 21:12 ` Toshi Kani
2013-07-12 21:40 ` Rafael J. Wysocki
2013-07-12 22:28 ` Toshi Kani
2013-07-12 23:53 ` Rafael J. Wysocki
2013-07-15 16:11 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373474833-14047-1-git-send-email-toshi.kani@hp.com \
--to=toshi.kani@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox