From: oliver@neukum.org
To: lenb@kernel.org, rjw@sisk.pl, trenn@suse.de, linux-acpi@vger.kernel.org
Cc: Oliver Neukum <oneukum@suse.de>
Subject: [PATCH] ACPI:remove panic in case hardware has changed after S4
Date: Thu, 11 Jul 2013 14:14:30 +0200 [thread overview]
Message-ID: <1373544870-15135-1-git-send-email-oliver@neukum.org> (raw)
From: Oliver Neukum <oneukum@suse.de>
Some BIOSes change hardware based on the state of
a laptop's lid. If the lid is closed, the touchpad is
disabled and the checksum changes.
Signed-off-by: Oliver Neukum <oneukum@suse.de>
---
drivers/acpi/sleep.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
index 9c1a435..14744e5 100644
--- a/drivers/acpi/sleep.c
+++ b/drivers/acpi/sleep.c
@@ -664,11 +664,9 @@ static void acpi_hibernation_leave(void)
/* Reprogram control registers */
acpi_leave_sleep_state_prep(ACPI_STATE_S4);
/* Check the hardware signature */
- if (facs && s4_hardware_signature != facs->hardware_signature) {
- printk(KERN_EMERG "ACPI: Hardware changed while hibernated, "
- "cannot resume!\n");
- panic("ACPI S4 hardware signature mismatch");
- }
+ if (facs && s4_hardware_signature != facs->hardware_signature)
+ printk(KERN_CRIT "ACPI: Hardware changed while hibernated, "
+ "success doubtful!\n");
/* Restore the NVS memory area */
suspend_nvs_restore();
/* Allow EC transactions to happen. */
--
1.8.1.4
next reply other threads:[~2013-07-11 12:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 12:14 oliver [this message]
2013-07-11 20:50 ` [PATCH] ACPI:remove panic in case hardware has changed after S4 joeyli
2013-07-12 7:31 ` Thomas Renninger
2013-07-12 7:37 ` Thomas Renninger
2013-07-12 8:45 ` joeyli
2013-07-15 11:29 ` Oliver Neukum
2013-07-15 11:40 ` Rafael J. Wysocki
2013-07-15 11:44 ` Oliver Neukum
2013-07-15 13:59 ` joeyli
-- strict thread matches above, loose matches on Subject: below --
2013-07-15 11:43 oliver
2013-07-15 11:55 ` Thomas Renninger
2013-07-15 12:09 ` Rafael J. Wysocki
2013-07-15 12:31 ` Henrique de Moraes Holschuh
2013-07-15 12:44 ` Thomas Renninger
2013-07-15 15:06 ` Henrique de Moraes Holschuh
2013-07-15 15:35 ` Oliver Neukum
2013-07-15 16:34 ` Henrique de Moraes Holschuh
2013-07-15 23:56 ` Rafael J. Wysocki
2013-07-16 7:30 ` Thomas Renninger
2013-07-17 14:58 ` Thomas Renninger
2013-07-17 22:09 ` Rafael J. Wysocki
2013-07-31 23:52 ` joeyli
2013-07-16 7:32 ` joeyli
2013-07-16 12:12 ` Rafael J. Wysocki
2014-01-10 9:51 oliver
2014-01-11 1:21 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373544870-15135-1-git-send-email-oliver@neukum.org \
--to=oliver@neukum.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=rjw@sisk.pl \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).