From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Gnatenko Subject: Re: [Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8 Date: Wed, 17 Jul 2013 16:03:03 +0400 Message-ID: <1374062583.1836.1.camel@ThinkPad-X230.localdomain> References: <1370818899-8595-1-git-send-email-matthew.garrett@nebula.com> <2132122.eIEvjmIrrj@vostro.rjw.lan> <1374038198.1884.1.camel@ThinkPad-X230.localdomain> <1953381.pqik7pbieu@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-lb0-f169.google.com ([209.85.217.169]:47505 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754531Ab3GQMDI (ORCPT ); Wed, 17 Jul 2013 08:03:08 -0400 In-Reply-To: <1953381.pqik7pbieu@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Matthew Garrett , Aaron Lu , "linux-acpi@vger.kernel.org" , "daniel.vetter@ffwll.ch" , "seth.forshee@canonical.com" , "joeyli.kernel@gmail.com" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "lenb@kernel.org" On Wed, 2013-07-17 at 13:38 +0200, Rafael J. Wysocki wrote: > On Wednesday, July 17, 2013 09:16:38 AM Igor Gnatenko wrote: > > On Wed, 2013-07-17 at 00:01 +0200, Rafael J. Wysocki wrote: > > > On Tuesday, July 16, 2013 05:08:16 PM Matthew Garrett wrote: > > > > On Tue, 2013-07-16 at 17:32 +0400, Igor Gnatenko wrote: > > > > > Hmm. I found regression in user-space. In GNOME (maybe and ot= her DEs) we no longer see switch status of backlight. > > > >=20 > > > > Yeah, I can duplicate that. Rafael, we have to call > > > > acpi_video_init_brightness() even if we're not going to initial= ise the > > > > backlight - Thinkpads seem to use this as the trigger for enabl= ing ACPI > > > > notifications rather than handling it in firmware. This seems t= o do the > > > > job: > > >=20 > > > Igor, does this additional patch from Matthew help? > > Yes. With this patch I have backlight switch indicator on my ThinkP= ad X230. >=20 > OK, thanks for the confirmation. >=20 > Can you please also check if applying the appended patch on top of th= e Matthew's > one changes anything (ie. things still work)? Yes. I've tested and not found regressions in indicator or in switcher.= Good work. >=20 > Rafael >=20 >=20 > --- Tested-by: Igor Gnatenko > drivers/acpi/video.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > Index: linux-pm/drivers/acpi/video.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- linux-pm.orig/drivers/acpi/video.c > +++ linux-pm/drivers/acpi/video.c > @@ -957,6 +957,11 @@ static void acpi_video_device_find_cap(s > if (result) > printk(KERN_ERR PREFIX "Create sysfs link\n"); > =20 > + } else { > + /* Remove the brightness object. */ > + kfree(device->brightness->levels); > + kfree(device->brightness); > + device->brightness =3D NULL; > } > } > =20 >=20 >=20 --=20 Igor Gnatenko =46edora release 19 (Schr=C3=B6dinger=E2=80=99s Cat) Linux 3.11.0-0.rc0.git7.1.fc20.x86_64 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html